Skip to content

Latest commit

 

History

History
349 lines (222 loc) · 7.79 KB

File metadata and controls

349 lines (222 loc) · 7.79 KB

Vets Who Code Feedback Template


Feedback Context

To: [Name of person receiving feedback] From: [Your name] Date: [YYYY-MM-DD] Type: Code Review | Mentorship | Peer Feedback | Performance Review | Other

Context:


The 5-Level Feedback Framework

Use these categories to communicate the urgency and importance of your feedback. Each level helps set clear expectations about what action (if any) is needed.


1. Praise

When to use: Recognize great work, growth, or positive behaviors you want to see continue.

What went well:

Why this matters:

Examples:


2. FYI ℹ️

When to use: Share minor observations or information that's good to know but doesn't require action.

Severity: Low - No action required Minor observations:

Context:

Examples:

  • "Heads up: The API we're using is being deprecated in v3.0, but we have 6 months to migrate"
  • "I noticed you're using forEach - just FYI, map() might be slightly more performant for large arrays"

3. Suggestion 💡

When to use: Offer improvements that would be nice to have but aren't critical.

Severity: Low-Medium - Optional but beneficial Potential improvements:

Area Current Approach Suggested Approach Benefit
[e.g., Function naming] [What they did] [What you suggest] [Why it helps]

Why this would help:

Resources:

Examples:

  • "Consider extracting this logic into a separate utility function for reusability"
  • "You might find using async/await more readable than promise chains here"

4. Recommendation ⚠️

When to use: Point out issues that should be addressed to prevent future problems.

Severity: Medium-High - Action recommended Important fixes or changes:

Issue Location Problem Recommended Solution Priority
[e.g., Error handling missing] [File:line] [What's wrong] [How to fix] High/Med

Impact if not addressed:

How to fix:

// Example of recommended approach

Resources:

Examples:

  • "The authentication flow doesn't validate JWT tokens - this creates a security vulnerability"
  • "This function doesn't handle edge cases where the API returns null"

5. Plea 🚨

When to use: Identify critical issues that must be fixed before proceeding.

Severity: Critical - Must be addressed immediately Critical issues:

Critical Issue Location Impact Required Action Deadline
[e.g., Security flaw] [File:line] [Consequences] [Must do this] [When]

Why this is critical:

Breaking point:

Action required:

Support available:

I'm available to pair program on this if needed. Reach me at [contact method].

Examples:

  • "This exposes user passwords in plain text in the database - we need to implement bcrypt hashing before this goes to production"
  • "The infinite loop in this function will crash the server under load"

Code-Specific Feedback

Code Quality

Readability:

Maintainability:

Performance:

Best Practices

What's aligned with best practices:

What could be improved:

Suggested learning resources:

Testing

Test coverage:

Test quality:


Growth & Development

Strengths Demonstrated

Technical skills:

Soft skills:

Growth Opportunities

Areas for development:

Skill Area Current Level Target Level How to Get There
[e.g., Testing] Beginner Intermediate [Resources/actions]

Recommended next steps:

Resources to help you level up:


Action Items

For the Recipient

Must do (before merge/completion):

  • [Critical action item]
  • [Critical action item]

Should do (recommended improvements):

  • [Recommended action]
  • [Recommended action]

Nice to have (future enhancements):

  • [Optional improvement]
  • [Optional improvement]

For the Reviewer (You)

Follow-up actions:

  • [Schedule pair programming session]
  • [Share additional resources]
  • [Review again after changes]

Timeline for follow-up: [When will you check in again?]


Final Thoughts 💭

Summary

Overall assessment:

Key takeaways:

Encouragement

Remember: Everyone starts somewhere, and every bug is a learning opportunity. Your growth is impressive, and I'm here to support you as you continue to level up your skills. Keep pushing forward!

Questions or Discussion

Open for discussion:

I'm happy to discuss any of this feedback. If something isn't clear or you disagree with any suggestions, let's talk it through. The best solutions often come from collaboration.

How to reach me: [Your contact information or preferred method]


Feedback Guidelines (For Reviewers)

When giving feedback, remember:

Do

  • Be specific: Reference exact line numbers, files, or examples
  • Be kind: Critique the code, not the person
  • Explain why: Help them understand the reasoning behind your feedback
  • Offer solutions: Don't just point out problems - suggest fixes
  • Recognize growth: Acknowledge improvement and effort
  • Ask questions: "Have you considered...?" is often better than "You should..."

Don't

  • Don't be vague: "This could be better" isn't helpful
  • Don't nitpick: Focus on what matters most
  • Don't assume intent: Ask for clarification if something seems odd
  • Don't just criticize: Balance critique with recognition of what's working
  • Don't forget empathy: Remember when you were learning too

The Golden Rule

Give feedback the way you'd want to receive it: honest, helpful, and with respect.


We're all on the same team. We succeed together. Aim High!