Fix various CI complaints

Author: justsmth

.github/workflows/analysis.yml

@@ -133,6 +133,9 @@ jobs:
       - name: Set Rust toolchain override
         run: rustup override set ${{ steps.toolchain.outputs.name }}
 
+      - name: Install valgrind
+        run: sudo apt-get update && sudo apt-get install -y valgrind
+
       - name: Install cargo-udeps
         run: cargo install cargo-udeps
 
@@ -243,12 +246,14 @@ jobs:
         with:
           package: aws-lc-rs
           feature-group: default-features
+          rust-toolchain: 1.90.0
       - name: Check semver (FIPS)
         uses: obi1kenobi/cargo-semver-checks-action@v2
         with:
           package: aws-lc-rs
           feature-group: only-explicit-features
           features: fips
+          rust-toolchain: 1.90.0
   metadata-checks:
     if: github.repository_owner == 'aws'
     runs-on: ubuntu-latest
@@ -402,7 +407,7 @@ jobs:
           submodules: 'recursive'
       - uses: dtolnay/rust-toolchain@stable
       - name: Install readelf
-        run: sudo apt-get update && sudo apt-get install -y binutils
+        run: sudo apt-get update && sudo apt-get install -y binutils valgrind
       - name: Build project
         run: cargo build --workspace --all-targets --release
       - name: Check for GNU-stack section in object files

aws-lc-rs-bench/src/benchmarks.rs

@@ -9,21 +9,19 @@
 
 use std::hint::black_box;
 
-use aws_lc_rs::{
-    aead::{
-        Aad, BoundKey, Nonce, NonceSequence, OpeningKey, SealingKey, UnboundKey, AES_128_GCM,
-        AES_256_GCM, CHACHA20_POLY1305, NONCE_LEN,
-    },
-    agreement::{self, EphemeralPrivateKey, UnparsedPublicKey, X25519},
-    digest::{self, Context as DigestContext},
-    error::Unspecified,
-    hkdf::{Salt, HKDF_SHA256, HKDF_SHA384},
-    hmac::{self, Context as HmacContext},
-    rand::SystemRandom,
-    signature::{
-        self, EcdsaKeyPair, Ed25519KeyPair, KeyPair, RsaKeyPair, ECDSA_P256_SHA256_FIXED_SIGNING,
-        ECDSA_P384_SHA384_FIXED_SIGNING, ED25519,
-    },
+use aws_lc_rs::aead::{
+    Aad, BoundKey, Nonce, NonceSequence, OpeningKey, SealingKey, UnboundKey, AES_128_GCM,
+    AES_256_GCM, CHACHA20_POLY1305, NONCE_LEN,
+};
+use aws_lc_rs::agreement::{self, EphemeralPrivateKey, UnparsedPublicKey, X25519};
+use aws_lc_rs::digest::{self, Context as DigestContext};
+use aws_lc_rs::error::Unspecified;
+use aws_lc_rs::hkdf::{Salt, HKDF_SHA256, HKDF_SHA384};
+use aws_lc_rs::hmac::{self, Context as HmacContext};
+use aws_lc_rs::rand::SystemRandom;
+use aws_lc_rs::signature::{
+    self, EcdsaKeyPair, Ed25519KeyPair, KeyPair, RsaKeyPair, ECDSA_P256_SHA256_FIXED_SIGNING,
+    ECDSA_P384_SHA384_FIXED_SIGNING, ED25519,
 };
 
 /// A benchmark definition