feat: migrate off of tslint and use eslint

Author: parker-snyk

.eslintignore

@@ -0,0 +1,2 @@
+dist/
+node_modules/

.eslintrc.json

@@ -0,0 +1,29 @@
+{
+  "root": true,
+  "parser": "@typescript-eslint/parser",
+  "plugins": ["@typescript-eslint"],
+  "extends": [
+    "eslint:recommended",
+    "plugin:@typescript-eslint/recommended",
+    "prettier"
+  ],
+  "rules": {
+    "no-shadow": "off",
+    "@typescript-eslint/no-shadow": "off",
+    "@typescript-eslint/naming-convention": "off",
+    "no-bitwise": "off",
+    "max-classes-per-file": "off",
+    "no-console": "off",
+    "@typescript-eslint/no-explicit-any": "off",
+    "no-case-declarations": "off",
+    "no-useless-escape": "off",
+    "no-prototype-builtins": "off",
+    "@typescript-eslint/no-var-requires": "off",
+    "@typescript-eslint/no-namespace": "off",
+    "no-control-regex": "off",
+    "@typescript-eslint/no-unused-vars": ["error", {
+      "argsIgnorePattern": "^_",
+      "varsIgnorePattern": "^_"
+    }]
+  }
+}

lib/analyzer/image-inspector.ts

@@ -377,7 +377,7 @@ function isLocalImageSameArchitecture(
   return platformArchitecture === inspectResultArchitecture;
 }
 
-async function pullIfNotLocal(targetImage: string, options?: DockerOptions) {
+async function pullIfNotLocal(targetImage: string, _options?: DockerOptions) {
   const docker = new Docker();
   try {
     await docker.inspectImage(targetImage);

lib/analyzer/package-managers/apk.ts

@@ -54,7 +54,6 @@ function parseLine(
       break;
     case "r": // Depends
     case "D": // Depends
-      // tslint:disable-next-line:no-duplicate-variable
       for (let name of value.split(" ")) {
         if (name.charAt(0) !== "!") {
           name = name.split("=")[0];

lib/dockerfile/instruction-parser.ts

@@ -16,7 +16,6 @@ export {
 };
 
 // Naive regex; see tests for cases
-// tslint:disable-next-line:max-line-length
 const installRegex =
   /(rpm\s+-i|rpm\s+--install|apk\s+((--update|-u|--no-cache)\s+)*add(\s+(--update|-u|--no-cache))*|apt-get\s+((--assume-yes|--yes|-y)\s+)*install(\s+(--assume-yes|--yes|-y))*|apt\s+((--assume-yes|--yes|-y)\s+)*install|dnf\s+((--assumeyes|--best|--nodocs|--allowerasing|-y)\s+)*install(\s+(--assumeyes|--best|--nodocs|--allowerasing|-y))*|microdnf\s+((--nodocs|--best|--assumeyes|-y)\s+)*install(\s+(--nodocs|--best|--assumeyes|-y))*|yum\s+install|aptitude\s+install)\s+/;
 

lib/dockerfile/instruction-updater.ts

@@ -40,7 +40,7 @@ function updateDockerfileBaseImageName(
   const argRanges = dockerfile
     .getARGs()
     .filter((arg) => arg.getProperty()?.getValue() === currentBaseImageName)
-    .map((arg) => arg.getProperty()?.getValueRange()!);
+    .map((arg) => arg.getProperty()!.getValueRange()!);
 
   const ranges = fromRanges.concat(argRanges);
 

lib/extractor/decompress-maybe.ts

@@ -63,7 +63,7 @@ export function decompressMaybe(): Transform {
 
           // Setup zstd decompressor with streaming API
           zstdStream = new ZstdDecompress(
-            (data: Uint8Array, final?: boolean) => {
+            (data: Uint8Array, _final?: boolean) => {
               transform.push(Buffer.from(data));
             },
           );

lib/extractor/oci-archive/layer.ts

@@ -214,7 +214,7 @@ async function tryParseJsonMetadata(stream: Readable): Promise<unknown> {
       // Keep a no-op error handler to prevent unhandled error events
       // when the stream is drained after fast-fail
       stream.removeAllListeners("error");
-      // tslint:disable-next-line:no-empty
+      // eslint-disable-next-line @typescript-eslint/no-empty-function
       stream.on("error", () => {});
     };
 

lib/go-parser/go-binary.ts

@@ -288,6 +288,7 @@ export function readRawBuildInfo(binary: Elf): RawBuildInfo {
   const buildInfoAlign = 16;
   const buildInfoSize = 32;
 
+  // eslint-disable-next-line no-constant-condition
   while (true) {
     const i = data.toString("binary").indexOf(buildInfoMagic);
     if (i < 0 || data.length - i < buildInfoSize) {

lib/inputs/redHat/static.ts

@@ -19,7 +19,7 @@ export function getRedHatRepositoriesFromExtractedLayers(
       if (!contentManifest || !contentManifest.content_sets) {
         continue;
       }
-      repositories.push(...contentManifest?.content_sets);
+      repositories.push(...contentManifest.content_sets);
     }
   }