Skip to content

ITS: speedup final step in vertexer#15279

Merged
shahor02 merged 2 commits intoAliceO2Group:devfrom
f3sch:its/vtx/speedup
Apr 16, 2026
Merged

ITS: speedup final step in vertexer#15279
shahor02 merged 2 commits intoAliceO2Group:devfrom
f3sch:its/vtx/speedup

Conversation

@f3sch
Copy link
Copy Markdown
Collaborator

@f3sch f3sch commented Apr 15, 2026

@shahor02 this sets the preliminary Pb-Pb as default in the Config and overwrites for pp with the (rounded) settings I sent you.

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch f3sch marked this pull request as ready for review April 15, 2026 11:42
@f3sch f3sch requested review from a team, fprino, mconcas, mcoquet642 and shahor02 as code owners April 15, 2026 11:42
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 15, 2026

Error while checking build/O2/fullCI_slc9 for 7cfe145 at 2026-04-16 07:56:

++ cp /sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local11/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonpath([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2_SRC=/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0
++ [[ -e /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/CMakeLists.txt ]]

Full log here.

@f3sch
Copy link
Copy Markdown
Collaborator Author

f3sch commented Apr 15, 2026

@shahor02 any idea why the matching crashed in the CI? I don't see how it is related to this code for the moment.

@shahor02
Copy link
Copy Markdown
Collaborator

@shahor02 any idea why the matching crashed in the CI? I don't see how it is related to this code for the moment.

@f3sch where do you see this? I see that the gcc was killed in O2Physics building, apparently due to the memory problems.

@f3sch
Copy link
Copy Markdown
Collaborator Author

f3sch commented Apr 15, 2026

@shahor02 any idea why the matching crashed in the CI? I don't see how it is related to this code for the moment.

@f3sch where do you see this? I see that the gcc was killed in O2Physics building, apparently due to the memory problems.

In the aarch64 (which I know is not required)

@shahor02
Copy link
Copy Markdown
Collaborator

Hm, no idea, but it was failing there already yesterday. I'll run locally full_CI

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Comment on lines +517 to 519
if (!rofVertices[rofId].empty() && cluster.getSize() < mVrtParams[iteration].suppressLowMultDebris) {
continue;
}
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahor02, this now suppresses lower multiplicity secondary vertices (disabled for pp) preferring the highest mult. ones.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for pp this is set to 0 in dpl-workflow.sh

Copy link
Copy Markdown
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good now, just left a comment about duplication of settings in the O2DPG PR.

@shahor02
Copy link
Copy Markdown
Collaborator

Failures unrelated, merging together with related AliceO2Group/O2DPG#2323

@shahor02 shahor02 merged commit 97af522 into AliceO2Group:dev Apr 16, 2026
12 of 14 checks passed
@f3sch f3sch deleted the its/vtx/speedup branch April 16, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants