Add C# client customizations for ContainerInstance mgmt SDK migration#42361
Draft
ArcturusZhang wants to merge 6 commits intoAzure:mainfrom
Draft
Add C# client customizations for ContainerInstance mgmt SDK migration#42361ArcturusZhang wants to merge 6 commits intoAzure:mainfrom
ArcturusZhang wants to merge 6 commits intoAzure:mainfrom
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…rators Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- DnsNameLabelReusePolicy → AutoGeneratedDomainNameLabelScope - Enum casing: TCP→Tcp, UDP→Udp, Noreuse→NoReuse - Property renames: AddressType, IP, OSType, IPAddressType, etc. - Uri/ResourceIdentifier alternateType: VaultBaseUri, IdentityUri, ResourceId - Probe property renames: InitialDelayInSeconds, PeriodInSeconds, TimeoutInSeconds Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
12 tasks
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
- Move client.tsp/back-compatible.tsp changes from ContainerInstance.Management/ to resource-manager/Microsoft.ContainerInstance/ContainerInstance/ - Remove incorrect ContainerInstance.Management/ directory - Fix ContainerGroupProfile/NGroup: TrackedResourceWithOptionalLocation → ProxyResource with explicit location?/tags? properties for TrackedResourceData inheritance - Add emitter entry to tspconfig.yaml Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Restore @@clientLocation decorators for ContainerGroupProfiles ops with 'csharp' scope (needed so C# generator routes CRUD ops to the correct resource, not the CGProfile interface) - Use ArmTagsProperty spread instead of inline tags for ContainerGroupProfile and NGroup - Add doc comment for location property Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeSpec for ContainerInstance Management - C# SDK Migration
Adding TypeSpec project for ContainerInstance management plane, converted from Swagger via
@autorest/openapi-to-typespecv0.11.13, with C# client customizations for backward compatibility during SDK migration to the new@azure-typespec/http-client-csharp-mgmtemitter.What's included
specification/containerinstance/ContainerInstance.Management/main.tsp,models.tsp,ContainerGroup.tsp,ContainerGroupProfile.tsp,NGroup.tsp,routes.tspclient.tsp— ~80+ C#@@clientName/@@alternateType/@@accessdecorators for backward compatibilityback-compatible.tsp—@@Legacy.flattenProperty,@@Legacy.hierarchyBuilding,@@clientLocationdecoratorstspconfig.yamlwith@azure-typespec/http-client-csharp-mgmtemitter configuredRelated SDK PR