Skip to content

Pin Playwright version#38104

Open
chidozieononiwu wants to merge 1 commit intomainfrom
PlaywrightBrowserDownload
Open

Pin Playwright version#38104
chidozieononiwu wants to merge 1 commit intomainfrom
PlaywrightBrowserDownload

Conversation

@chidozieononiwu
Copy link
Copy Markdown
Member

Packages impacted by this PR

appnetwork - mgmt

Issues associated with this PR

NA

Describe the problem that is addressed by this PR

  • This pins playwright version to the latest and uses an environment variable to override the download URL for the chrome browser.
  • The browser binaries are stored in Azure Blob Storage and will need to be versioned with playwright.

Copilot AI review requested due to automatic review settings April 10, 2026 23:22
@github-actions github-actions bot added the dev-tool Issues related to the Azure SDK for JS dev-tool label Apr 10, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the Playwright browser installation used by dev-tool run test:vitest --browser, and updates the install logging to indicate whether a custom Playwright download host is being used.

Changes:

  • Pins Playwright installation to playwright@1.59.1 via npx playwright@1.59.1 install.
  • Reads PLAYWRIGHT_DOWNLOAD_HOST and updates logging to reflect whether installs come from a custom host or the default CDN.

Comment on lines +54 to +56
command: "npx playwright@1.59.1 install",
name: "playwright install",
env : {
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using npx playwright@1.59.1 install hard-codes a Playwright version that is currently different from the repo’s pinned testing catalog (pnpm-workspace.yaml catalogs.testing.playwright is ^1.58.2). This can cause npx to fetch a separate Playwright version (and potentially prompt interactively) instead of using the locally installed one, making CI runs slower/flaky and risking browser/runtime mismatch. Prefer invoking the workspace-installed Playwright (npx playwright install / pnpm exec playwright install) and pin the version centrally (update the catalog) or otherwise keep the install version in sync with the catalog; if you must keep npx playwright@..., add the non-interactive flag so it can’t hang in CI.

Suggested change
command: "npx playwright@1.59.1 install",
name: "playwright install",
env : {
command: "pnpm exec playwright install",
name: "playwright install",
env: {

Copilot uses AI. Check for mistakes.
Comment on lines +56 to +58
env : {
...process.env,
},
Copy link

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The env : { ...process.env } block is redundant here (child processes inherit process.env by default) and the env : spacing is inconsistent with the repo’s Prettier formatting. Consider removing the env override entirely, or at least formatting it as env: and only overriding specific variables when needed.

Suggested change
env : {
...process.env,
},

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev-tool Issues related to the Azure SDK for JS dev-tool Do Not Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants