Conversation
There was a problem hiding this comment.
Pull request overview
Pins the Playwright browser installation used by dev-tool run test:vitest --browser, and updates the install logging to indicate whether a custom Playwright download host is being used.
Changes:
- Pins Playwright installation to
playwright@1.59.1vianpx playwright@1.59.1 install. - Reads
PLAYWRIGHT_DOWNLOAD_HOSTand updates logging to reflect whether installs come from a custom host or the default CDN.
| command: "npx playwright@1.59.1 install", | ||
| name: "playwright install", | ||
| env : { |
There was a problem hiding this comment.
Using npx playwright@1.59.1 install hard-codes a Playwright version that is currently different from the repo’s pinned testing catalog (pnpm-workspace.yaml catalogs.testing.playwright is ^1.58.2). This can cause npx to fetch a separate Playwright version (and potentially prompt interactively) instead of using the locally installed one, making CI runs slower/flaky and risking browser/runtime mismatch. Prefer invoking the workspace-installed Playwright (npx playwright install / pnpm exec playwright install) and pin the version centrally (update the catalog) or otherwise keep the install version in sync with the catalog; if you must keep npx playwright@..., add the non-interactive flag so it can’t hang in CI.
| command: "npx playwright@1.59.1 install", | |
| name: "playwright install", | |
| env : { | |
| command: "pnpm exec playwright install", | |
| name: "playwright install", | |
| env: { |
| env : { | ||
| ...process.env, | ||
| }, |
There was a problem hiding this comment.
The env : { ...process.env } block is redundant here (child processes inherit process.env by default) and the env : spacing is inconsistent with the repo’s Prettier formatting. Consider removing the env override entirely, or at least formatting it as env: and only overriding specific variables when needed.
| env : { | |
| ...process.env, | |
| }, |
Packages impacted by this PR
appnetwork - mgmtIssues associated with this PR
NA
Describe the problem that is addressed by this PR