fix(eng/tsconfigs): add customConditions: ["browser"] to test.browser.json#38133
Merged
deyaaeldeen merged 1 commit intomainfrom Apr 14, 2026
Merged
fix(eng/tsconfigs): add customConditions: ["browser"] to test.browser.json#38133deyaaeldeen merged 1 commit intomainfrom
deyaaeldeen merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the browser test TypeScript configuration with the existing browser source configuration so conditional exports (e.g., "browser" condition used by #platform/*-style imports) resolve correctly during browser test type-checking.
Changes:
- Add
compilerOptions.customConditions: ["browser"]toeng/tsconfigs/test.browser.jsonto matcheng/tsconfigs/src.browser.json.
….json The shared browser source tsconfig (src.browser.json) already has customConditions: ["browser"], but the test browser tsconfig was missing it. This means browser test files that import from packages using #platform/* subpath imports with a "browser" condition would not resolve to the correct browser-specific implementation during type-checking. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
deyaaeldeen
force-pushed
the
fix/browser-test-customconditions
branch
from
bd6333b to
b05f550
Compare
xirzec
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
customConditions: ["browser"]toeng/tsconfigs/test.browser.jsonto matchsrc.browser.json. Without this,#platform/*subpath imports with a"browser"condition don't resolve correctly in browser test configs.