Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix du focus du mixin hover, pour rester cohérent avec le focus de base qui est focus-visible : https://github.com/BeAPI/beapi-frontend-framework/blob/master/src/scss/04-utilities/_focus.scss#L8
Note
Low Risk
Low risk: a small selector change limited to hover/focus styling; may slightly alter keyboard-focus behavior where
:focuspreviously applied but:focus-visibledoes not.Overview
Updates the
hovermixin in_m-hover.scssto use&:focus-visible(instead of&:focus) alongside:hover/:active, aligning its focus behavior with the project’sfocus-visibleutility and reducing unwanted focus styles for non-keyboard interactions.Reviewed by Cursor Bugbot for commit ef4a0c4. Bugbot is set up for automated code reviews on this repo. Configure here.