PDF: Started building system to allow custom DOMPDF font loading#6109
Open
ssddanbrown wants to merge 1 commit intodevelopmentfrom
Open
PDF: Started building system to allow custom DOMPDF font loading#6109ssddanbrown wants to merge 1 commit intodevelopmentfrom
ssddanbrown wants to merge 1 commit intodevelopmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a way for custom fonts to be loaded for use with DomPDF.
On export, BookStack scans the
storage/fonts/dompdffolder for*.ttffont files, then for each attempts to build the required.ufm(font-metrics) file where they don't already exist.Then it auto-converts the naming scheme to suit dompdf.
Considerations
This is just one side of things, making the font available. It would also need to be used in styles. We could attempt to auto-inject styles, but then things may get complex with factors like font ordering, different fonts for different uses etc...
Might be best, at least for now, if we provide guidance (alongside guidance for this system) on how to set the relevant styles (via custom HTML head content).
Todo
storage/fontssub-folders.Docs Updates
storage/fontsfolder (and all folders within that) are accessible & writable to the web-server.