Skip to content

fix: resolve open dependabot security alerts#110

Open
jonathannorris wants to merge 7 commits intomainfrom
fix/dependabot-security-alerts
Open

fix: resolve open dependabot security alerts#110
jonathannorris wants to merge 7 commits intomainfrom
fix/dependabot-security-alerts

Conversation

@jonathannorris
Copy link
Copy Markdown
Member

Summary

Resolved 9 open Dependabot security alerts by bumping vulnerable dependencies.

Dependabot Alerts Resolved

Alert Package Severity Fix
#7 requests medium Bumped minimum to 2.33.0 in requirements.txt
#8 requests medium Bumped minimum to 2.33.0 in setup.py (via requirements.txt)
#6 requests medium Bumped minimum to 2.33.0 (transitive via parent package)
#14 pytest medium Bumped minimum to 9.0.3 in requirements.test.txt
#9 Django high Bumped minimum to 6.0.4 in example/django-app
#10 Django medium Bumped minimum to 6.0.4 in example/django-app
#11 Django high Bumped minimum to 6.0.4 in example/django-app
#12 Django low Bumped minimum to 6.0.4 in example/django-app
#13 Django low Bumped minimum to 6.0.4 in example/django-app

black>=26.3.1 requires Python 3.10+, but unit tests run on 3.9.
Move black, mypy, and ruff into a separate requirements.lint.txt
used only by the lint workflow (Python 3.12).
- requests >= 2.33.0 to address CVE (medium, alerts #7, #8)
- pytest >= 9.0.3 to address vulnerability (medium, alert #14)
- django >= 6.0.4 in example app to address multiple CVEs (alerts #9-#13)
@jonathannorris jonathannorris requested a review from a team as a code owner April 22, 2026 19:47
Copilot AI review requested due to automatic review settings April 22, 2026 19:47
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Resolves multiple Dependabot security alerts by bumping minimum versions of vulnerable Python dependencies and aligning CI to a dedicated lint dependency set.

Changes:

  • Bumped requests minimum version in requirements.txt.
  • Bumped test dependency pytest minimum version and reorganized dev dependencies by introducing requirements.lint.txt.
  • Bumped example Django app minimum Django version and updated the lint workflow to install lint-only requirements.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
requirements.txt Raises minimum requests version to address security alerts.
requirements.test.txt Updates pytest minimum version and trims lint-only tooling from test deps.
requirements.lint.txt New lint requirements file (black/mypy/ruff + type stubs).
example/django-app/requirements.txt Raises minimum Django version for the example app.
.github/workflows/lint.yml Switches lint CI to install from requirements.lint.txt.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread requirements.lint.txt Outdated
Comment thread requirements.test.txt Outdated
Comment thread example/django-app/requirements.txt
Python 3.9 reached EOL in October 2025. requests>=2.33.0 requires
Python>=3.10, so we replace 3.9 with 3.10 in the test matrix.
- Relax types-requests and types-urllib3 pin to allow versions
  compatible with requests >= 2.33.0 and urllib3 >= 1.15.1
- Update django example README to reflect Django 6.0.4+ requirement
Copilot AI review requested due to automatic review settings April 24, 2026 13:50
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/unit_test.yml
Comment thread example/django-app/README.md Outdated
Comment thread requirements.test.txt Outdated
Comment thread requirements.lint.txt Outdated
@jonathannorris jonathannorris enabled auto-merge (squash) April 24, 2026 13:57
- setup.py: raise python_requires to >=3.10 (Django 6.0 requires 3.10+,
  CI matrix already reflects this)
- example/django-app/README.md: update "Python 3.7+" -> "Python 3.10+"
- requirements.test.txt: tighten pytest>=9.0.3 -> pytest~=9.0.3 for reproducibility
- requirements.lint.txt: align types-requests~=2.32.0 -> ~=2.33.0 with bumped runtime dep
Copilot AI review requested due to automatic review settings April 24, 2026 20:47
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread setup.py
Comment on lines +27 to 28
python_requires=">=3.10",
packages=find_packages(),
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python_requires is bumped from >=3.9 to >=3.10, which is a breaking support-policy change and is not mentioned in the PR description (which frames this as dependency bumps only). If dropping 3.9 support is intentional, please also update the repo’s documented/checked minimums (e.g., README Requirements and pyproject’s tool configs currently reference 3.9) and consider whether a major version bump/release note is needed; otherwise revert this to keep 3.9 support.

Copilot uses AI. Check for mistakes.
Comment thread requirements.test.txt
Comment on lines +3 to 4
pytest~=9.0.3
pytest-benchmark~=4.0.0
Copy link

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requirements.test.txt now requires pytest~=9.0.3, but pyproject.toml’s [tool.pytest.ini_options] minversion is still set to 7.0. This mismatch can cause confusing failures depending on how pytest is invoked; update the configured minversion to match the dependency (or keep pytest in the 7.x/8.x range if that’s the intended minimum).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants