Get fuzztests running daily in CI#267
Draft
apoelstra wants to merge 4 commits intoElementsProject:masterfrom
Draft
Get fuzztests running daily in CI#267apoelstra wants to merge 4 commits intoElementsProject:masterfrom
apoelstra wants to merge 4 commits intoElementsProject:masterfrom
Conversation
honggfuzz is faster but has always been unreliable and frustrating to keep working; I eventually removed it entirely from my local CI and we removed it from the Github CI here in rust-elements. AFL, meanwhile, I think we literally never used, though we copied it from Matt's old rust-lightning stuff. Anyway, something that works is better than something that's fast, so move to libfuzzer, which I can run in both my local CI and in Github.
Now that we aren't using hongfuzz, we have reasonably well-behaved deps in the fuzz list. So we can add this to the workspace, so that our fuzztests are being tested and linted.
…the fuzztests fail Copied from rust-bitcoin, but deleted the Kani stuff which doesn't apply here. I ran all four of the fuzztests locally on one core for 60 seconds to sanity check that they actually work. So hopefully we don't have spurious failures here.
Member
Author
|
My local CI does not like this because libfuzzer-sys won't build on 1.63 due to MSRV. Meanwhile, I cannot bump the MSRV of I propose we just bump the MSRV of this whole crate to 1.74 to match the rust-bitcoin ecosystem. |
Member
Author
|
Blocked on #269. |
Member
|
Merged #269 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from rust-bitcoin: run the fuzztests every day in Github CI, file issues when they fail.
Convert the fuzztests from honggfuzz to cargo-fuzz, which is (maybe) slower but much more reliable.