Skip to content

Extract index key scanning from index creation task#9011

Open
livius2 wants to merge 1 commit intoFirebirdSQL:masterfrom
livius2:idx-extract-key-scanner
Open

Extract index key scanning from index creation task#9011
livius2 wants to merge 1 commit intoFirebirdSQL:masterfrom
livius2:idx-extract-key-scanner

Conversation

@livius2
Copy link
Copy Markdown

@livius2 livius2 commented Apr 25, 2026

Hi

This is a preparatory refactoring for a future optimizer statistics change. It extracts the relation/key scanning loop from IndexCreateTask::handler() into a reusable helper that computes index keys and delegates per-key processing to a sink/callback.

No behavior change is intended.
I added a small test:
idx_key_scanner_refactor_test.py

MSG                             regular rebuild OK
MSG                             expression rebuild OK
MSG                             partial unique rebuild OK
MSG                             unique duplicate check OK
MSG                             primary key null check OK
MSG                             foreign key bad data rejected OK
MSG                             foreign key valid data accepted OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant