chore(devdeps): update dawidd6/action-download-artifact action to v6 [security]#577
Conversation
|
|
View your CI Pipeline Execution ↗ for commit d7a06d7
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (15.67%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
===========================================
- Coverage 70.90% 15.67% -55.24%
===========================================
Files 53 154 +101
Lines 2021 26666 +24645
Branches 377 1127 +750
===========================================
+ Hits 1433 4180 +2747
- Misses 588 22486 +21898 🚀 New features to boost your workflow:
|
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
|
Deployed 7da49bf to https://ForgeRock.github.io/ping-javascript-sdk/pr-577/7da49bf73ea350faadb1a759c29be743172ec837 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/device-client - 0.0 KB (-9.9 KB, -100.0%) 📊 Minor Changes📉 @forgerock/device-client - 9.9 KB (-0.0 KB) ➖ No Changes➖ @forgerock/davinci-client - 48.0 KB 14 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
This PR contains the following updates:
v3→v6Artifact poisoning vulnerability in action-download-artifact v5 and earlier
GHSA-5xr6-xhww-33m4
More information
Details
Summary
In versions of
dawidd6/action-download-artifactbefore v6, a repository's forks were also searched by default when attempting to find matching artifacts. This could be exploited by an unprivileged attacker to introduce compromised artifacts (such as malicious executables) into a privileged workflow context, as creating a fork requires no privileges.Users should immediately upgrade to v6 or newer, which changes the default behavior to avoid searching forks for matching artifacts. Users who cannot upgrade should explicitly set
allow_forks: falseto disable searching forks for artifacts.Details
GitHub's artifact storage for workflows does not natively distinguish between artifacts created by a repository and artifacts created by forks of that repository. As a result, attempting to retrieve the "latest" artifact for a workflow run can return artifacts produced by a fork, rather than its upstream.
Because any GitHub user can create a fork of a public repository, this allows for artifact poisoning in the following scenarios (as well as potentially others):
alice/foorunsbuild.yml, producingbuild.exealice/foorunspublish.yml, which usesaction-download-artifact@v5to retrieve the latestbuild.exefrombuild.ymlTo compromise
publish.ymlin this scenario, Mallory forksalice/footomallory/foo, and then modifiesbuild.ymlto produce a compromisedbuild.exe. Mallory can then repeatedly trigger their copy ofbuild.ymlto ensure that their compromisedbuild.exeis always the latest artifact, meaning that Alice'spublish.ymlwill retrieve it.Additional details on this vulnerability can be found in this blog post from 2022:
Impact
This vulnerability impacts all repositories on GitHub that use
action-download-artifacts@v5or older and do not disableallow_forks: true, which is the default.If a repository is affected, the severity ranges from downstream contamination (such as publishing attacker-controlled artifacts) to direct workflow compromise (if the retrieved artifact is then executed in a privileged workflow context, such as
pushorpull_request_target).Severity
CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:H/VA:N/SC:N/SI:N/SA:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
dawidd6/action-download-artifact (dawidd6/action-download-artifact)
v6Compare Source
Full Changelog: dawidd6/action-download-artifact@v5...v6
v5Compare Source
Full Changelog: dawidd6/action-download-artifact@v4...v5
v4Compare Source
What's Changed
New Contributors
Full Changelog: dawidd6/action-download-artifact@v3...v4
v3.1.4Compare Source
What's Changed
New Contributors
Full Changelog: dawidd6/action-download-artifact@v3...v3.1.4
v3.1.3Compare Source
What's Changed
Full Changelog: dawidd6/action-download-artifact@v3.1.2...v3.1.3
v3.1.2Compare Source
What's Changed
New Contributors
Full Changelog: dawidd6/action-download-artifact@v3.1.1...v3.1.2
v3.1.1Compare Source
What's Changed
Full Changelog: dawidd6/action-download-artifact@v3...v3.1.1
v3.1.0Compare Source
What's Changed
New Contributors
Full Changelog: dawidd6/action-download-artifact@v3...v3.1.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.