chore: do-actual-poll by ryanbas21 · Pull Request #582 · ForgeRock/ping-javascript-sdk

ryanbas21 · 2026-04-24T19:52:21Z

JIRA Ticket

N/A

Description

Poll endpoints with polling like functionality.

changeset-bot · 2026-04-24T19:52:26Z

⚠️ No Changeset found

Latest commit: 5cf17fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-04-24T19:52:29Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b327e70f-0458-41df-ab77-266e7d295989

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch polling-refactor2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-24T19:53:06Z

View your CI Pipeline Execution ↗ for commit 5cf17fa

Command	Status	Duration	Result
`nx affected -t build lint test typecheck e2e-ci`	❌ Failed	2m 8s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-24 21:07:03 UTC

pkg-pr-new · 2026-04-24T19:55:55Z

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/davinci-client@582

@forgerock/device-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/device-client@582

@forgerock/journey-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/journey-client@582

@forgerock/oidc-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/oidc-client@582

@forgerock/protect

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/protect@582

@forgerock/sdk-types

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-types@582

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-utilities@582

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/iframe-manager@582

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-logger@582

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-oidc@582

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-request-middleware@582

@forgerock/storage

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/storage@582

commit: bbfbb15

github-actions · 2026-04-24T19:56:24Z

Deployed 7d6b348 to https://ForgeRock.github.io/ping-javascript-sdk/pr-582/7d6b3486af948042e9c014f732ba26a4d8ccf859 branch gh-pages in ForgeRock/ping-javascript-sdk

github-actions · 2026-04-24T19:56:33Z

📦 Bundle Size Analysis

🚨 Significant Changes

🔻 @forgerock/device-client - 0.0 KB (-9.9 KB, -100.0%)
🔻 @forgerock/journey-client - 0.0 KB (-89.9 KB, -100.0%)

📊 Minor Changes

📉 @forgerock/device-client - 9.9 KB (-0.0 KB)
📈 @forgerock/davinci-client - 48.8 KB (+0.9 KB)

➖ No Changes

➖ @forgerock/oidc-client - 25.2 KB
➖ @forgerock/sdk-utilities - 11.2 KB
➖ @forgerock/sdk-types - 7.9 KB
➖ @forgerock/protect - 150.1 KB
➖ @forgerock/journey-client - 89.9 KB
➖ @forgerock/storage - 1.5 KB
➖ @forgerock/sdk-oidc - 4.8 KB
➖ @forgerock/sdk-request-middleware - 4.5 KB
➖ @forgerock/sdk-logger - 1.6 KB
➖ @forgerock/iframe-manager - 2.4 KB

14 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated

Current Size: Total gzipped size of all files in the package's dist directory
Baseline: Comparison against the latest build from the main branch
Files included: All build outputs except source maps and TypeScript build cache
Exclusions: .map, .tsbuildinfo, and .d.ts.map files

_{🔄 Updated automatically on each push to this PR}

codecov-commenter · 2026-04-24T19:56:39Z

Codecov Report

❌ Patch coverage is 1.75439% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.49%. Comparing base (5d6747a) to head (bbfbb15).
⚠️ Report is 37 commits behind head on main.

Files with missing lines	Patch %	Lines
...ges/davinci-client/src/lib/client.store.effects.ts	1.85%	53 Missing ⚠️
packages/davinci-client/src/lib/client.store.ts	0.00%	3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (1.75%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #582       +/-   ##
===========================================
- Coverage   70.90%   53.49%   -17.41%     
===========================================
  Files          53       22       -31     
  Lines        2021     2417      +396     
  Branches      377      335       -42     
===========================================
- Hits         1433     1293      -140     
- Misses        588     1124      +536

Files with missing lines	Coverage Δ
packages/davinci-client/src/lib/client.types.ts	`100.00% <ø> (ø)`
packages/davinci-client/src/lib/client.store.ts	`0.29% <0.00%> (ø)`
...ges/davinci-client/src/lib/client.store.effects.ts	`41.30% <1.85%> (ø)`

... and 72 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nx-cloud

Nx Cloud is proposing a fix for your failed CI:

We updated client.store.effects.test.ts to align with the refactored polling API introduced by this PR. The old isChallengeStillPending and interpretChallengeResponse functions were replaced by classifyChallengeResponse, and PollingMode shapes changed, causing both the typecheck and test tasks to fail. These changes replace the obsolete test coverage with new assertions against classifyChallengeResponse's discriminated union outcomes and the updated getPollingModeµ return shapes.

Tip

✅ We verified this fix by re-running @forgerock/davinci-client:typecheck, @forgerock/davinci-client:test.

Warning

The suggested diff is too large to display here, but you can view it on Nx Cloud ↗

Or Apply changes locally with:

npx nx-cloud apply-locally HIr0-jSkp

Apply fix locally with your editor ↗ View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

ryanbas21 force-pushed the polling-refactor2 branch from 1b7ece6 to bbfbb15 Compare April 24, 2026 19:59

chore: do-actual-poll

5cf17fa

ryanbas21 force-pushed the polling-refactor2 branch from bbfbb15 to 5cf17fa Compare April 24, 2026 20:59

nx-cloud Bot reviewed Apr 24, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: do-actual-poll#582

chore: do-actual-poll#582
ryanbas21 wants to merge 1 commit intomainfrom
polling-refactor2

ryanbas21 commented Apr 24, 2026

Uh oh!

changeset-bot Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 24, 2026 •

edited

Loading

Review skipped

Uh oh!

nx-cloud Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Apr 24, 2026 •

edited

Loading

Uh oh!

nx-cloud Bot left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

ryanbas21 commented Apr 24, 2026

JIRA Ticket

Description

Uh oh!

changeset-bot Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

nx-cloud Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🚨 Significant Changes

Legend

Uh oh!

codecov-commenter commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nx-cloud Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Nx Cloud is proposing a fix for your failed CI:

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Apr 24, 2026 •

edited

Loading

coderabbitai Bot commented Apr 24, 2026 •

edited

Loading

nx-cloud Bot commented Apr 24, 2026 •

edited

Loading

pkg-pr-new Bot commented Apr 24, 2026 •

edited

Loading

github-actions Bot commented Apr 24, 2026 •

edited

Loading

github-actions Bot commented Apr 24, 2026 •

edited

Loading

codecov-commenter commented Apr 24, 2026 •

edited

Loading

nx-cloud Bot left a comment •

edited

Loading