feat: structured health check endpoints with dependency status#3304
Open
nikhil-bora wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Open
feat: structured health check endpoints with dependency status#3304nikhil-bora wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
nikhil-bora wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Add a reusable healthcheck package to the frontend service that reports per-dependency health with aggregate roll-up: - Three-state model: healthy / degraded / unhealthy - Critical vs non-critical dependencies: a critical failure (e.g. cart, checkout) makes the service unhealthy; non-critical failure (e.g. ad service) results in degraded status - Concurrent dependency probes with configurable timeout - Convenience helper for gRPC connection state checks - /health returns structured JSON with per-dependency latency and errors - /livez returns simple liveness probe for K8s livenessProbe - Unit tests covering all status transitions and timeout behavior Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
healthcheckGo package with three-state model (healthy/degraded/unhealthy) and per-dependency probing/health(structured JSON) and/livez(simple liveness) endpoints into the frontend serviceTest plan
go test ./healthcheck/...to verify all unit tests pass/healthreturns JSON with all dependency statuses/healthreturns degraded (200)/healthreturns unhealthy (503)/livezalways returns 200 as long as the process is running/healthendpoint🤖 Generated with Claude Code