feat: Resolve OOM in high-cardinality dimension merging [DATA-23847]#20
Open
quocnguyendinh wants to merge 4 commits intomasterfrom
Open
feat: Resolve OOM in high-cardinality dimension merging [DATA-23847]#20quocnguyendinh wants to merge 4 commits intomasterfrom
quocnguyendinh wants to merge 4 commits intomasterfrom
Conversation
- Replace O(n) dict-based merge with O(1) two-pointer generator - Use server-side cursors with generator factory pattern for true DB streaming - Fix check_date sort priority in dimension tuple ordering - Fix MergedCountCheck dimensions property and equality check - Inline diff logging in _merge_by_check_date, remove _build_check_summary Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…om __eq__ Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
quocnguyendinh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves OOM when dimension columns have high cardinality by making the merge pipeline memory-efficient.
_build_check_summaryand related helper methods — instead log invalid diffs inline during_merge_by_check_dateto avoid materializing the full merged list a second timecheck_datesort priority in dimension tuple to match SQLORDER BYJira: DATA-23847
Test plan