Skip to content

PropertyColumn: do not cast float/decimal columns as varchar #7617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-nicka merged 2 commits into from
Apr 25, 2026
Merged

PropertyColumn: do not cast float/decimal columns as varchar #7617

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6a56eb
PropertyColumn: do not cast float/decimal columns as varchar
labkey-nicka Apr 21, 2026
c0a51e9
Use switch
labkey-nicka Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions api/src/org/labkey/api/exp/PropertyColumn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ public void setParentIsObjectId(boolean id)
@Override
public SQLFragment getValueSql(String tableAlias)
{
String cast = getPropertySqlCastType();
SQLFragment sql = new SQLFragment("(SELECT ");
if (isMvIndicatorColumn())
{
Expand All @@ -232,6 +231,8 @@ else if (_pd.getPropertyType() == PropertyType.BOOLEAN)
else
sql.append(getTableAlias(tableAlias)).append(".ObjectId");
sql.append(")");

String cast = getPropertySqlCastType();
if (null != cast)
{
sql.insert(0, "CAST(");
Expand Down Expand Up @@ -262,23 +263,21 @@ static private String getPropertyCol(@NotNull PropertyDescriptor pd)
};
}

private String getPropertySqlCastType()
private @Nullable String getPropertySqlCastType()
{
if (isMvIndicatorColumn())
return null;
PropertyType pt = _pd.getPropertyType();
if (PropertyType.DOUBLE == pt || PropertyType.DATE_TIME == pt)
return null;
else if (PropertyType.TIME == pt)
return "TIME";
else if (PropertyType.DATE == pt)
return "DATE";
else if (PropertyType.INTEGER == pt)
return "INT";
else if (PropertyType.BOOLEAN == pt)
return getParentTable().getSqlDialect().getBooleanDataType();
else
return getParentTable().getSqlDialect().getSqlTypeName(JdbcType.VARCHAR) + "(" + PropertyStorageSpec.DEFAULT_SIZE + ")";

return switch (_pd.getPropertyType())
{
case DOUBLE, DATE_TIME, DECIMAL, FLOAT -> null;
case TIME -> "TIME";
case DATE -> "DATE";
case INTEGER -> "INT";
case BOOLEAN -> getParentTable().getSqlDialect().getBooleanDataType();
case null, default -> getParentTable().getSqlDialect().getSqlTypeName(JdbcType.VARCHAR) +
"(" + PropertyStorageSpec.DEFAULT_SIZE + ")";
};
}

public PropertyDescriptor getPropertyDescriptor()
Expand Down
Loading