Fix missing opencsd header in trc_tgt_mem_access_i.h#87
Open
c722996 wants to merge 1 commit intoLinaro:masterfrom
Open
Fix missing opencsd header in trc_tgt_mem_access_i.h#87c722996 wants to merge 1 commit intoLinaro:masterfrom
c722996 wants to merge 1 commit intoLinaro:masterfrom
Conversation
Contributor
|
Please provide context and example of failing use case for this. The library compiles correctly without this change. |
Author
|
Hi Mike, While implementing a custom memory accessor, I encountered compilation failures when including Currently, the header relies on transitive includes and violates the "Include What You Use" (IWYU) principle. This patch explicitly includes the missing dependencies (e.g., ocsd_if_types.h) to make the header fully self-contained and prevent future build breaks. |
Contributor
|
The interface applies to mappers not accessors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.