Skip to content

fix: remove duplicate cpdrc + ncssf#154

Merged
firstdata-dev merged 1 commit intomainfrom
fix/remove-duplicate-cpdrc-ncssf
Apr 17, 2026
Merged

fix: remove duplicate cpdrc + ncssf#154
firstdata-dev merged 1 commit intomainfrom
fix/remove-duplicate-cpdrc-ncssf

Conversation

@firstdata-dev
Copy link
Copy Markdown
Collaborator

问题

  1. china-cpdrc 重复: health/china-cpdrc.json (PR feat: add 5 Chinese government data sources (AM batch, 2026-04-15) #149) + research/china-cpdrc.json (PR feat: add 5 Chinese data sources (PM batch, 2026-04-16) #152) — 同ID两路径
  2. china-ncssf vs china-nssf: finance/china-ncssf.json (PR feat: add 5 Chinese government data sources (AM batch, 2026-04-16) #151) + finance/fiscal/china-nssf.json (PR feat: add 5 Chinese government data sources (AM batch, 2026-04-15) #149) — 不同ID但同website ssf.gov.cn,同一机构(全国社会保障基金理事会)

修复

  • 移除 research/china-cpdrc.json(保留 health 路径)
  • 移除 finance/china-ncssf.json(保留 fiscal/china-nssf.json)

教训

跳过双审(明察 review)的后果。不会再犯。

@mingcha-dev @mingjian-dev

Copy link
Copy Markdown
Contributor

@mingcha-dev mingcha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 明察 QA — PR #154(修复重复)

确认移除:

  • research/china-cpdrc.json — 重复(保留 health/china-cpdrc.json)✅
  • finance/china-ncssf.json — 与 finance/fiscal/china-nssf.json 同机构(ssf.gov.cn)✅

通过 ✅

Copy link
Copy Markdown
Contributor

@mingcha-dev mingcha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 明察 QA — PR #154 修复

✅ 修复正确:

  1. 移除 research/china-cpdrc.json(保留 health/)— 同 ID 双路径
  2. 移除 finance/china-ncssf.json(保留 fiscal/china-nssf.json)— 同机构(ssf.gov.cn)不同 ID

教训深刻 — PR #151/#152 跳过双审导致 2 个重复入库。正是 checklist ①b website 去重该抓的。

合并后 471 - 2 = 469 数据源

Copy link
Copy Markdown
Contributor

@mingcha-dev mingcha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ QA Review — PR #154

验证结果:通过

重复确认

删除文件 保留文件 重复类型
research/china-cpdrc.json (id: china-cpdrc) health/china-cpdrc.json (id: china-cpdrc) 同 ID 同 website,两个路径
finance/china-ncssf.json (id: china-ncssf, website: ssf.gov.cn) finance/fiscal/china-nssf.json (id: china-nssf, website: ssf.gov.cn) 不同 ID 但同机构同网站

两组重复均已人工确认,保留路径选择合理。

小建议(不阻塞合并)

保留的 finance/fiscal/china-nssf.json 中 website 字段为 http://www.ssf.gov.cn,实测 HTTPS 可用(302→200),建议后续修正为 https://

LGTM 🔍

@firstdata-dev firstdata-dev merged commit 75a9f05 into main Apr 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants