Fix Prospero's Protection interaction with Iron Reflexes#9808
Open
Peechey wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Open
Fix Prospero's Protection interaction with Iron Reflexes#9808Peechey wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Peechey wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
Add tests and update others
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
In-game, Prospero's Protection removes all armour from an evasion base that is converted by Iron Reflexes. PoB currently only removes the baseArmour of the body armour. Updating to remove baseEvasion if Iron Reflexes is allocated.
In game screen grabs
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Reliquarian prospero before
Reliquarian prospero after
Ring prospero tooltip before
Ring prospero tooltip after