Draft
Conversation
vaisest
commented
Apr 24, 2026
| if node.oidx == data.orbitIndex and not data.isMastery then | ||
| for _, extendedId in ipairs(importedGroups[proxyGroup].nodes) do | ||
| if id == tonumber(extendedId) and inExtendedHashes(id) then | ||
| if id == extendedId and inExtendedHashes(tonumber(id)) then |
Contributor
Author
There was a problem hiding this comment.
Hopefully this doesn't break anything else. The cluster data is exactly the same as previously, but this seemed to be comparing strings to numbers. Type hints / checking would be really useful here, because I'm not sure what is correct here
Contributor
Author
|
The import changes will probably end up being rather broad as it seems really difficult to try to combine the old and new UI. Currently trying to make the oauth version simpler and then I can add the account search back in. I think the oauth version could just be two menus for either logged in or not, but atm rate limiting is an issue (2 per 10s or 5 per 300s) is an issue so it probably needs to have a manual refresh button for looking up realm characters 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: