Skip to content

Add support for showing Required Attributes in comparison tooltips#9813

Draft
Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Peechey:feature/required-stat-tooltip
Draft

Add support for showing Required Attributes in comparison tooltips#9813
Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Peechey:feature/required-stat-tooltip

Conversation

@Peechey
Copy link
Copy Markdown
Contributor

@Peechey Peechey commented Apr 24, 2026

Description of the problem being solved:

A lot of times when I'm comparing gear or pasting items from trade the stats look PERFECT until I slot it and realize "oh that item was giving me strength that I needed" and I have to start my search all over and manually add the attribute in the search or switch gear around yada yada. This PR will show the required stat during comparisons. If you're over the required stat value and add more or removing the node/item doesn't put you below the requirement, it will not show in the tooltip.

I'd like to update the trader weights or at least add the ability to include the required attributes as a trader weight as well, but I haven't thought that one through and I'm not sure how much people want it anyways.

Steps taken to verify a working solution:

  • Validate tree and item comparison tooltips

Link to a build that showcases this PR:

eNqtHGtz2kjy8_pXqKi6qrs6gpFAgF32bgGG2Hd2QsBJbvdLaiwNMJuRRKSRbXYr__26Rw8kXh4h5UMiRv2ann5NzyhXv706XHumfsA897qmN5o1jbqWZzN3cV37_Dh-16v99uvZ1YSI5cf5IGQc3_x69suVfNaeiGszcV374Lm0pjmEuTPP-k7Fe98LV0CvpnH6TDk8mTXN4iQIPhCHXtdmFvCraSSwqGsPN-MRnRVxxZJ67gP50_Pfe_bOOHNz49aS-MQS1L9HZv1QeA-eDdSEH8LbZ0Zfot93D5OP08eaJoi_oOJLMuvWt2YNpvTL1YSTNfVngggtgL-ua33QDFnQWyaADOEh0GjWzo_CDkI_EDfEgce3cWYrSu0UrN0w2ocghz4TDyEXbMUZ9VMUvWEewgChh0viWhsx9OZBQR49QfjNZPa2yBGkt1GIqXd7DaNrmAcl-crEEjCy5NWQBhzUoyQVQt8tXCaoMvjEY4HnFppzsRkMQ87BWZQ4TGlA_WcimKJEQ895Ym5eOW9L9EBcMvSCzNodg5xQH7xT5BCabyDMqOWBQ2dRDL1hKLDZj3yQ3z2bU3XIQlOJEYpKc9o8RjNVuMKETxNoCoFLDXLmhVwRUmwilnEQ6oa-KkDduRuGumkcdqgfeUjzMNtnT8hspBQGRreTDdX2RaNrdvVu12y3OheH8CbLdcAswh_IK3NCBwLzI_lONwwNo3fYsBZL4UIUOYSrtw-KO2Y-PQFt6HH7FLQl8YLDeK1jrqOiCUiV1iUC37mWmkN-dn0ZVTMZ9qim53QKfoJZ_IlTVZQNk9jdVLJtxGtB3ZjhWm1C95Ray_dQY02JoGohOeNQzaOaRWAlzSLgPs02FTEKqAkR96vJbLSOIRVU1Mil_mI9WzLK7WLQiWBDslIq9qzLLLaSvvPsCtlMFrWgSr4S31bLFUVleiZBNtjqnePqisDVLJNCuQgINt2qew9iTHzvT2oJxouh9X3HC33FBY-AlSaQ5Ilo9zCldmipJabRfI7TeKYDDrsv1WmkWCAn54VQ-0IQ6_uNZy-UlSaZFMLIyzcLVyuIIWgNqgQwAUJhzTIlyruOAvRHMGUlj8ZUqc5gA63MIE3_6ly2UNTngvm7wGQ24Mos0gV9gGDhQBKQ21_Ymme2s82DddoYtlNKeyMJmN-sHXY57wWEX2I_ICgGDaVOinAwGY196v61VqafA1diMHLt0EdvUOaxjbGPzSNzIJYGwQ0RRAso8a3lPSz0da2mBbK9M2ZcUP8GxpASctPsuIz-QnxGXKHL5s_WoCEHNwTHhPMnCCRAGBlfncumEj4NPXfOFhqR5hL9mFGB6FLAdERjtqQpmOAUa_k5CbmQQHLuFl2C11Ffc2V7ibrUWcsmUU1zQ-eJ-te1Xtxz2QfvpB2XEWLegrzeC_jWmMPrDQn9MAXJMU16KUIzrYj3Ia3SvJSoeIOaVOAHmWWjXoJkvoWEsSlpWiVIhtF-a2K5oJHgtZoqWNvcehcdlXXIL8EM0xAI4EBAsQfrPudrpVWZLcGMI2T1VUzSfgLf0S96F0dkxnJkd_10U2EpCq9f3EhM4LtNFSs5YcHj0sTjfErcLG5XxcImNOMDrTcQ0kR2gpg7eVNZkagXVTEDtmD841xmBTAmGX4VjGljzNiGpD61pSUOvRAyIuXzIrbib5q86RSPmL3lQeQtavfIZHsNjvm4FQVnKH6FT_gjW0DOxLkpiSg55gvh01Z-3yJenaeJQ6ab6Bc-PvqUfmH0RQuW3gtmyxsGxQqkY4sGyTnCX57n3EenGZ0ki82Ej1kRX_0P6qVex2j02r1o4HcI1obR6FxETaqr2XfGeQAZ1BfvqRMM1lChJLQlW6hwo3eP6xWy7d_f1-IUKHHjDAhZVWY5AIzFcT3fSdtL2fefQsKZWMsEjSzu6YJYa-R-XZsTHiDnrDhj3Crmu8tSbwn7ON1GKyAHNepiu8ROJoJHQP2NyEPCrUAKvfVCjjHX4qFN79y4tkuF4uQJ5xUx-uUK5Nvms6DOnY17PkFsqFLO7wTM4Rwnci7pwxO68oASUAjaB9pj4gFgHtqUQKoIEHRCfLGRUw4h6RRUQkbs33PviXA9PVmKyppd6PjQy2hmWEjqWTJGQsZC75Cvf2zWKzbzaDaR8SarIG03siZ8vHPQbDT6iv8gp3WiR2l2UjPH7DqyMARLDCwMaNQy_krJynPlcERRCoKgWUuYghrE-lKb9qejsw_gRAhwNoCSUpuAl3CtDyGPirOhT-aC2pca8j2b-HTOXi81PMI78mMWzt_48bePqeiy2bhotX7euQI2ixBzYIbGmfSPKf1xqXW7Z6AnziwmgktNP_sb4nVwCRtKSOkWrTvEJT9TQubPf7Z778zOv_6BJupTElBbw8aSJrsd1JcHNRq2Us7-rXc14WlZvnLhYFsjU2RSoUrasLCNNPjlIIxdiCtp1KnGM9Xu8fUBz-SeiIPiLeUOIPaf1kFAuBadzmom-B6QnDx9nt5j_MIfaMWp2WUoDDx7rUW1zzYZowAZsPlnGmxT0EtT6BSgsF8Z7dIyFFFntGSaUUYTA88TQZlppELMXshqm1CrtD5a1ZhXu6xKTlgXfa9K2hUscBVGUmhpMNoWctEB5aKMWeasqgAebOWC7-UdoFWWQOcUc6k8HJUPiUZVkUAvaTxmVYK0C9u9XpXrF9VBAfCoLDqAoB80mBOUelo8LmyIRR2wAPwUa3a9KIJRFKF87mtXZXitqpynUzgUt6vJ33rpWNiqSplmyUhmVKMRs2yK0itIUVXQOLmyqqAIMiqQv4qCrrhflS3GOhVI3S7tlMXnXdF-oFVSfa0KDKcKGkbpJaiswitrkRVlik7ZuGhUlSg6VRGqbInMwu52SnA-jhK1oqLWIzbLiU1nsv_9lWK_PYhOb2WnEZ9kE1IjqxV17bSna9NAMFd2zqD05bymzZbeS99-xuOLR8_jQa5tKTuyUfPLXYWJuLKb-i1q6--cYOQgHRZY357C-Ryv_te0QPjyk4bReDwaPt59GcUoMyrv2MjOWtxf5TAECOFTEL27ruHJgHx5QwVhPMCWLedkFVA7K3Oe2u3m1CRLS9LJvFOg9BU07TMsr7OERq_UB4UuNm8VSMmL-zviRLLgDS48-VciFB84ZklFl4KGJBDRHTMFKni0lCeCI2pTuXNWhG8pNxlTmQBOHA9asCse7FGKwEOYFbXYnFkxjNqqJwdyOd1YVugTa61EQ372kMePhxSQo88a8tjJmIpW5UcUW1qNx1Tsi1ryXCWDHQ8pIKd3FPME0mHPlR_iKFAacdpnHK8Yba3sB8-Vxg5-swFQIPgA0SS6vrRF8COe4KZvFCiBl_jsKRTb7pwdV9GVvDadU5McUZmLvBecRY1GVPSauymbi0a5N2pBbYtENKKAmhzqZ5GjMcUliLsbOfXHYypKSG7z5OafDKo4iQy3_WeP2buRYudlWYLyYmcFcuHVzfJktu9yKlGUZc2WvyRjJ6J_FgxPWvdQkYeiakTQ5cpRQM8rR-GRuZYIfapEYLpTjky3i5ADmOn9wlyyTgZPxE_vIp5MIboxeTK6vLqjgo3x_4bO5bn5ngSweaWYS_bTGntQ0UG5QYSqZxymNROhexP6VZCSU9wfkU5TV5x692rtAMUoqMRfFe3Gy_iFcnQ6RAjqglvVAvQgpfSe8y0lHD809Xg5gjufVZUhht9qhCvi2gm5j_vq_sLLAJtyoCkv8N7gJYmyOpS3DXcJpXJdnSc7RHl5K7knJW_5xLeE8YfmwH6E-uu4RMO9rQsbQnhod5oXRt3UL4xWvdNst5t1s9drtertXrfbq7eMrt6st1pm26zrvSaOd5sdo67rnV6vbrbaZqdudnSzVW91O1293ur0zF69beK40W3rZr190WkmH71HW-ns5-7xSCCvcRB_3c-_chmYjMBLaZuP1I0eUgtxOrckWI7x0tfmI3YjvvsBG_jo1tRSiFVweX7-8vLSWBGx9Ob0lXHasDznfAVsQFvv5Hb6HfI578OfwaLfH91_eliLSfD-vvPfeY_cDD__8Soufhc_Ptx8MnTn8T_tb53gj4E_7t2OAeU6uqWUcL2KmhZB3GhA0_IZqDvuIuCKyLXDJcOHDx4UvPgOB-MfV-fb_9vA_wEfr6Cj

After screenshot:

Scorching Ray 155 Int Required
image

image image

@Peechey Peechey changed the title Add support for showing Required Stats in comparison tooltips Add support for showing Required Attributes in comparison tooltips Apr 24, 2026
@Peechey
Copy link
Copy Markdown
Contributor Author

Peechey commented Apr 24, 2026

Didn't see #6413 until posting this, I could remove the m_max I'm doing in the diff and show the "overcapped" attributes, though it would be displayed like "-x Intelligence Required" in Positive Color without additional changes. I'd probably try to use a different label.

Although... they kind of want it in the sidebar and that isn't the same as what this PR applies 🤷

@mcagnion
Copy link
Copy Markdown
Contributor

FYI, two branches on my fork around the same ideas :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants