Group remaining ruby indexer tests into submodules#723
Open
alexcrocha wants to merge 7 commits intomainfrom
Open
Group remaining ruby indexer tests into submodules#723alexcrocha wants to merge 7 commits intomainfrom
alexcrocha wants to merge 7 commits intomainfrom
Conversation
alexcrocha
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #649
Follow-up to #717
This PR groups the remaining ungrouped tests in
ruby_indexer_tests.rsinto dedicated submodules:mixin_tests(10 tests)alias_tests(12 tests)dynamic_namespace_tests(13 tests)constant_alias_tests(7 tests)comment_tests(14 tests)promotability_tests(5 tests + group-specific macros)diagnostic_tests(2 tests)After this PR, all ruby indexer tests are organized into 19 submodules with no tests remaining at the top level.
Best reviewed commit by commit