fix(ci): replace close/reopen hack with workflow_dispatch for bot PRs#1210
Open
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Open
fix(ci): replace close/reopen hack with workflow_dispatch for bot PRs#1210John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Conversation
- Add actions:write permission to trigger CI via workflow_dispatch - Branch from HEAD~1 so PR is behind main, enabling "Update branch" button - Add "Trigger CI checks" step using gh workflow run ci.yml - Enhance job summary with PR link and enterprise workflow instructions Ported from SocketDev/socket-sdk-js#592.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: HEAD~1 branching breaks validation diff comparison
- Changed
git diff --name-only origin/main..HEADto use three-dot syntax (origin/main...HEAD) which compares the merge-base against HEAD, so only Claude's branch changes are validated instead of also including the skipped commit's changes.
- Changed
Or push these changes by commenting:
@cursor push 35b046df68
Preview (35b046df68)
diff --git a/.github/workflows/weekly-update.yml b/.github/workflows/weekly-update.yml
--- a/.github/workflows/weekly-update.yml
+++ b/.github/workflows/weekly-update.yml
@@ -224,7 +224,7 @@
if: steps.final.outputs.success == 'true'
run: |
UNEXPECTED=""
- for file in $(git diff --name-only origin/main..HEAD); do
+ for file in $(git diff --name-only origin/main...HEAD); do
case "$file" in
package.json|*/package.json|pnpm-lock.yaml|*/pnpm-lock.yaml|.npmrc|pnpm-workspace.yaml) ;;
src/*|test/*) ;;You can send follow-ups to the cloud agent here.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e337f8b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
actions: writepermission to trigger CI viaworkflow_dispatchHEAD~1so PR is behind main, enabling the "Update branch" buttongh workflow run ci.ymlPorted from SocketDev/socket-sdk-js#592.
Test plan
workflow_dispatchNote
Cursor Bugbot is generating a summary for commit e337f8b. Configure here.