Skip to content

fix: clean up check-new-deps hook#1211

Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom
fix-check-new-deps-hook
Apr 17, 2026
Merged

fix: clean up check-new-deps hook#1211
John-David Dalton (jdalton) merged 1 commit intomainfrom
fix-check-new-deps-hook

Conversation

@jdalton
Copy link
Copy Markdown
Contributor

@jdalton John-David Dalton (jdalton) commented Apr 16, 2026

Summary

  • Remove dead low-quality-score warning logic (the malware API only checks for malware, not scores)
  • Remove incorrect comment about SDK batch routing heuristic
  • Rename critical variable to malware for clarity

Test plan

  • cd .claude/hooks/check-new-deps && npm test

Note

Low Risk
Behavior is narrowed to malware-only blocking with mostly removal/cleanup; limited risk aside from potentially no longer surfacing non-blocking low-score warnings.

Overview
Simplifies the check-new-deps pre-tool hook to only block on malware results from SocketSdk.checkMalware(), removing the previous low-quality-score warning path and related return structure.

Updates messaging/comments/docs to match the new behavior (malware-only blocking), and renames internal variables for clarity when evaluating alerts.

Reviewed by Cursor Bugbot for commit 55fab25. Configure here.

The malware API only checks for malware, not quality scores.
Remove dead warned/score logic and the wrong SDK batch heuristic
comment.
@jdalton John-David Dalton (jdalton) merged commit 7509286 into main Apr 17, 2026
7 checks passed
@jdalton John-David Dalton (jdalton) deleted the fix-check-new-deps-hook branch April 17, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants