chore(templates): minify: false in package-builder esbuild configs#1214
Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom Apr 17, 2026
Merged
chore(templates): minify: false in package-builder esbuild configs#1214John-David Dalton (jdalton) merged 1 commit intomainfrom
John-David Dalton (jdalton) merged 1 commit intomainfrom
Conversation
Both package-builder templates (cli-package and cli-sentry-package) shipped with minify: true in their esbuild.index.mts. Flip to false to match the repo-wide rule that shipped bundles never minify. Minification breaks ESM/CJS interop and makes debugging harder; the esbuild-minify validation scripts elsewhere in the org enforce this for finished packages. These templates should default to the same.
Bradley Farias (bmeck)
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flip
minify: true→minify: falsein both package-builder templates (cli-packageandcli-sentry-package).Why
Repo-wide rule: shipped bundles never minify. Minification breaks ESM/CJS interop and makes debugging harder. The
esbuild-minifyvalidation scripts elsewhere in the org (socket-lib, socket-packageurl-js, socket-registry, socket-sdk-js) already enforce this for finished packages. The templates should default to the same so newly-scaffolded packages are compliant out of the box.Files
packages/package-builder/templates/cli-package/.config/esbuild.index.mtspackages/package-builder/templates/cli-sentry-package/.config/esbuild.index.mtsPaired with similar cleanup in socket-cli#1213 (tsconfig sourcemaps).
Note
Low Risk
Template-only build output change; no runtime logic changes beyond producing unminified bundles.
Overview
Newly scaffolded
cli-packageandcli-sentry-packagetemplates now setminify: falsein theiresbuild.index.mtsconfigs, disabling minification for the generated CLI entry bundle.Reviewed by Cursor Bugbot for commit 2fe51b3. Configure here.