Skip to content

new landing page changes#522

Closed
sophia-you wants to merge 1 commit intomasterfrom
new-landing-page
Closed

new landing page changes#522
sophia-you wants to merge 1 commit intomasterfrom
new-landing-page

Conversation

@sophia-you
Copy link
Copy Markdown

No description provided.

@sophia-you sophia-you requested a review from angelina-ji April 15, 2026 23:14
@sophia-you sophia-you closed this Apr 15, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a35c2bf3b4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".


<div id="app"
class="row g-0"></div>
{% vite_asset 'src/landing.jsx' %}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Build src/landing.jsx into the Vite manifest

This template now requires src/landing.jsx, but the Vite build config still has a single input (src/index.jsx in frontend/vite.config.ts), so production builds will not emit a manifest entry for src/landing.jsx. In production mode (config/settings/production.py sets DJANGO_VITE["default"]["dev_mode"] = False), unauthenticated users rendering this template can hit a missing-asset failure instead of loading the landing page.

Useful? React with 👍 / 👎.

@@ -0,0 +1,63 @@
import React from 'react'
import 'styles/Landing.css'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use correct case in landing stylesheet import

The component imports styles/Landing.css, but the committed stylesheet is frontend/src/styles/landing.css (lowercase). On case-sensitive Linux filesystems this import cannot resolve, which breaks bundling for the new landing entrypoint, and also for the main app entrypoint because src/index.jsx now imports this component.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant