feat(accounts): add default notification configuration to settings#19005
Open
michael-smt wants to merge 1 commit intoWeblateOrg:mainfrom
Open
feat(accounts): add default notification configuration to settings#19005michael-smt wants to merge 1 commit intoWeblateOrg:mainfrom
michael-smt wants to merge 1 commit intoWeblateOrg:mainfrom
Conversation
Contributor
Author
|
The configuration syntax is probably not ideal, and it might be a bit too much documentation 😉 |
Member
|
I'm not really sure about this. This used to be an implementation detail, and we should probably think about this more before exposing it as configuration. |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎ Awaiting the start of a new Argos build… |
Contributor
Author
|
I'm also not so sure about this 🙂 But I thought better something than nothing... Maybe we could keep it undocumented, that would allow coming up with a better way to expose it as configuration later... |
michael-smt
force-pushed
the
feat/setting-default-notifications
branch
from
6f892e3 to
eb801c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows configuring the default notification configuration for newly created users in settings.
Implements some of #5155