Skip to content

fix(@angular-devkit/build-angular): fix app-shell route format and improve package resolution #33017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Apr 17, 2026
+5 −2
Merged

fix(@angular-devkit/build-angular): fix app-shell route format and improve package resolution #33017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/angular_devkit/build_angular/src/builders/app-shell/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,11 @@ async function _renderUniversal(
localeDirectory,
);

const route = options.route;
let html: string = await renderWorker.run({
serverBundlePath,
document: indexHtml,
url: options.route,
url: route?.[0] === '/' ? route : '/' + route,
Comment thread
alan-agius4 marked this conversation as resolved.
});

// Overwrite the client index file.
Expand Down
4 changes: 3 additions & 1 deletion packages/angular_devkit/build_angular/src/tools/webpack/utils/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import type { ObjectPattern } from 'copy-webpack-plugin';
import { createHash } from 'node:crypto';
import { createRequire } from 'node:module';
import * as path from 'node:path';
import { globSync } from 'tinyglobby';
import type { Configuration, WebpackOptionsNormalized } from 'webpack';
Expand Down Expand Up @@ -314,7 +315,8 @@ export function getStatsOptions(verbose = false): WebpackStatsOptions {
*/
export function isPackageInstalled(root: string, name: string): boolean {
try {
require.resolve(name, { paths: [root] });
const resolve = createRequire(root + '/').resolve;
Comment thread
alan-agius4 marked this conversation as resolved.
resolve(name);

return true;
} catch {
Expand Down
Loading