Skip to content

add experimental permission HttpApi slice#22385

Draft
kitlangton wants to merge 8 commits intodevfrom
kit/permission-httpapi-spike
Draft

add experimental permission HttpApi slice#22385
kitlangton wants to merge 8 commits intodevfrom
kit/permission-httpapi-spike

Conversation

@kitlangton
Copy link
Copy Markdown
Contributor

@kitlangton kitlangton commented Apr 14, 2026

Summary

  • move the shared permission route DTOs to Effect Schema with derived .zod compatibility where existing Hono boundaries still need it
  • add a parallel experimental permission HttpApi slice for list and reply under the existing instance-scoped experimental surface
  • cover the new permission HttpApi list/reply/docs flow with a server test and verify the touched permission and agent tests still pass

Verification

  • bun typecheck
  • bun run test test/server/permission-httpapi.test.ts
  • bun run test test/permission/next.test.ts
  • bun run test test/agent/agent.test.ts

Align the experimental question API schemas with the repo's Effect modeling style and keep the TUI answer rendering compatible with readonly arrays.
Decode pending question requests through the Schema.Class constructor path so the HttpApi list endpoint returns valid Question.Request instances while keeping QuestionID as a newtype.
Replace the ad hoc Object.assign wrapper with the shared schema helper so the Answer schema follows the same static attachment pattern as the rest of the codebase.
Capture the reusable pattern from the question HttpApi spike and turn the follow-up work into a checklist so the next route-group migrations can follow the same shape.
Move the shared permission route DTOs to Effect Schema, mount a parallel permission HttpApi surface, and cover the new list/reply/docs flow with a server test.
@kitlangton kitlangton marked this pull request as draft April 14, 2026 03:44
Share the permission reply field definition between the transport body and service input schemas and align the list contract with the readonly response style used by the question slice.
Base automatically changed from kit/question-httpapi-spike to dev April 14, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant