Allow skipping directories during type generation#6732
Open
OliverGilan wants to merge 1 commit intoanomalyco:devfrom
Open
Allow skipping directories during type generation#6732OliverGilan wants to merge 1 commit intoanomalyco:devfrom
OliverGilan wants to merge 1 commit intoanomalyco:devfrom
Conversation
Add an app-level typeIgnore config and thread it into SST's project discovery so JavaScript and Python projects can opt out of generated type files.
Collaborator
|
thanks for your contribution @OliverGilan could you take a look at #6675? maybe we could reuse its existing |
Contributor
Author
|
@vimtor I thought about doing that, it would definitely be cleaner than introducing a whole new config setting but I believe what I ran into is that the watcher doesn't run in all contexts where typegen happens. For example sst deploy will generate types but I don't believe there's any watcher in that context. I think for our purposes that's not a huge deal because we only deploy in CI so we could go that route if you prefer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an app-level typeIgnore config and thread it into SST's project discovery so JavaScript and Python projects can opt out of generated type files.
--
Problem
In a monorepo with many packages, a lot of them have nothing to do with SST yet SST insists on generating its types file in every directory where it finds a package.json or pyproject file.
Solution
This PR adds a simple config to ignore certain directories for type generation files