fix: add parentheses to fix operator precedence in co-author check#1199
Open
FuturizeRush wants to merge 1 commit intoanthropics:mainfrom
Open
fix: add parentheses to fix operator precedence in co-author check#1199FuturizeRush wants to merge 1 commit intoanthropics:mainfrom
FuturizeRush wants to merge 1 commit intoanthropics:mainfrom
Conversation
`??` has lower precedence than `!==`, so the expression: triggerDisplayName ?? triggerUsername !== "Unknown" parses as: triggerDisplayName ?? (triggerUsername !== "Unknown") When triggerDisplayName is an empty string "", the condition evaluates to "" (falsy), incorrectly skipping the co-author line even though the user is not "Unknown". Add parentheses to get the intended behavior: (triggerDisplayName ?? triggerUsername) !== "Unknown"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-character fix: adds parentheses to correct operator precedence in the co-author line construction.
Bug
src/create-prompt/index.ts:398—??has lower precedence than!==:When
triggerDisplayNameis""(empty string — notnull/undefined),??returns""which is falsy, so the co-author line is incorrectly omitted.Verified with JavaScript
Test plan
tsc --noEmitpassesdisplayName=""diverges