fix: handle 404 in checkHumanActor for bot/app actors#1213
Open
saarakelyan wants to merge 1 commit intoanthropics:mainfrom
Open
fix: handle 404 in checkHumanActor for bot/app actors#1213saarakelyan wants to merge 1 commit intoanthropics:mainfrom
saarakelyan wants to merge 1 commit intoanthropics:mainfrom
Conversation
Bot actors like github-merge-queue[bot] can't be looked up via
GET /users/{login} — the API returns 404. Previously this crashed
the action before it could check the allowed_bots list.
Now catches 404 and treats the actor as a Bot, allowing the
existing allowedBots logic to decide whether to proceed.
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot actors like github-merge-queue[bot] can't be looked up via GET /users/{login} — the API returns 404. Previously this crashed the action before it could check the allowed_bots list.
Now catches 404 and treats the actor as a Bot, allowing the existing allowedBots logic to decide whether to proceed.