Open
Conversation
…k to use this new framework. The README.md includes notes about other benchmarks which will be pushed after the initial work is accepted.
Contributor
Author
|
Moving back to draft as there are a number of improvements I want to make |
…r refactoring and writing the tests and I have reviewed all changes.
Contributor
Author
|
This should now be ready for review. |
Omega359
commented
Apr 18, 2026
| The sql benchmarks are organized in sub‑directories that correspond to the benchmark suites that are commonly used | ||
| in the community: | ||
|
|
||
| | Benchmark Suite | Description | |
Contributor
Author
There was a problem hiding this comment.
This readme covers all the test suites that I've converted for which I'll have additional PR's for each if this PR is merged.
Contributor
|
I will review this coming week 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Add a sql based benchmark framework with tpch as the initial benchmark to use this new framework. The README.md includes notes about other benchmarks which will have individual PR's after the initial work is accepted.
What changes are included in this PR?
benchmarking code only.
Are these changes tested?
Yes
Are there any user-facing changes?
benchmarks/bench.sh now uses the new framework for benchmarking tpch
Additional info
AI assisted with refactoring and writing tests. I have reviewed all AI produced code.