Add Jakarta REST client module for HttpClient#816
Add Jakarta REST client module for HttpClient#816arturobernalg wants to merge 3 commits intoapache:masterfrom
Conversation
7f1df04 to
7d4b01a
Compare
|
@arturobernalg Was this change-set AI generated? I have an impression it was authored by someone who has no familiarity with our code base. This is a start and a good proof of concept. Would you actually be willing to take your time and do it better? |
@ok2c Yes. I can rework it. If you have a specific direction in mind, please let me know |
Provide a small proxy-based Jakarta REST client implementation backed by the classic HttpClient API.
c232324 to
0798632
Compare
|
I reworked the patch to keep it small and direct, dropped the extra framework-like pieces, and aligned it more closely with the existing HttpClient style. |
The whole thing still looks like it just got vibe-coded with some AI agent. There is no need to rush it. Take your time to do it right. I think this can be the most important contribution to the project since @rschmitt reactive module. So, please take your time |
|
I haven't forgot of the PR. I just waiting for this change 54135f6 |
@arturobernalg I do not understand how this can be holding you back. This change in core allows for a custom content-type for JSON content, which looks like a corner case to me. I do not see how it is relevant here. |
fade429 to
8a5f5eb
Compare
@ok2c |
@arturobernalg Great! I will do a thorough review either this weekend or the next one the latest. This is the top priority change-set for me. |
This PR adds httpclient5-jakarta-rest-client, a small Java 11+ client-side module that creates implementations of jakarta.ws.rs-annotated interfaces with Apache HttpClient underneath.
The c/]qurrent implementation is intentionally minimal and focused on the client side only.