ci: optimize rerun workflow and add macOS RocksDB coverage#3010
Open
contrueCT wants to merge 5 commits intoapache:masterfrom
Open
ci: optimize rerun workflow and add macOS RocksDB coverage#3010contrueCT wants to merge 5 commits intoapache:masterfrom
contrueCT wants to merge 5 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Optimize the Rerun CI workflow so it only starts the rerun decision job when an upstream CI workflow actually fails.
Previously, the rerun workflow also ran for non-failure conclusions and then skipped inside the shell script, which created unnecessary workflow runs.
Main Changes
decide-rerun-action:github.event.workflow_run.conclusion == 'failure'CONCLUSIONshell variable and non-failure branch handlingpushpull_requestgh run rerun --failedbehavior unchangedVerifying these changes
.github/workflows/rerun-ci.ymlgit diff --check -- .github/workflows/rerun-ci.ymlDoes this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need