[improve][broker] Cache publish metadata and avoid repeated parsing in the broker send path#25555
Open
dao-jun wants to merge 3 commits intoapache:masterfrom
Open
[improve][broker] Cache publish metadata and avoid repeated parsing in the broker send path#25555dao-jun wants to merge 3 commits intoapache:masterfrom
dao-jun wants to merge 3 commits intoapache:masterfrom
Conversation
lhotari
reviewed
Apr 21, 2026
lhotari
reviewed
Apr 21, 2026
Member
lhotari
left a comment
There was a problem hiding this comment.
Yes, this is a very useful change. I've also been thinking of this when I added a similar optimization for the dispatcher side.
A few review comments.
Member
Author
|
@lhotari Thanks for your review, the most of pulsar downstream projects(kop, rop, mop...) are not maintained anymore now, maybe some private forks are active, but it's not our duty to maintain their downward compatibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ServerCnx.handleSend sits on the hot publish path, but the same MessageMetadata can be parsed multiple times for a single message. In the persistent-topic flow, producer-side encryption validation, delayed-delivery checks, and deduplication/chunk handling may all reparse the same payload. That adds avoidable CPU overhead
to a latency-sensitive path.
This change reduces that overhead by parsing metadata once per publish attempt and reusing it across the broker publish flow. It also keeps the behavior safe by invalidating the cached metadata after broker interceptors run, so any interceptor-side buffer mutation does not reuse stale data.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes