fix: accept AWS_IAM as valid gateway authorizer type in CLI flags#842
Closed
aidandaly24 wants to merge 1 commit intoaws:mainfrom
Closed
fix: accept AWS_IAM as valid gateway authorizer type in CLI flags#842aidandaly24 wants to merge 1 commit intoaws:mainfrom
aidandaly24 wants to merge 1 commit intoaws:mainfrom
Conversation
…s#819) The non-interactive `--authorizer-type AWS_IAM` flag was rejected by `validateAddGatewayOptions` because it used a hardcoded array that only included NONE and CUSTOM_JWT. The interactive TUI accepted AWS_IAM correctly via the Zod schema. Replace the hardcoded check with GatewayAuthorizerTypeSchema.safeParse() to stay in sync with the schema.
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-842-tarball/aws-agentcore-0.8.0.tgz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
agentcore add gateway --authorizer-type AWS_IAMwas rejected with "Invalid authorizer type. Use NONE or CUSTOM_JWT", even though the interactive TUI correctly offered AWS_IAM as a selectable option.Root cause:
validateAddGatewayOptionsinvalidate.tsused a hardcoded['NONE', 'CUSTOM_JWT']array instead of the Zod schemaGatewayAuthorizerTypeSchema(which includesAWS_IAM). The agent validation already used the schema-based approach — only the gateway validation was out of sync.Fix: Replace the hardcoded array with
GatewayAuthorizerTypeSchema.safeParse(), matching how agent authorizer validation already works. Also updateddocs/commands.mdto list all three valid values.Related Issue
Closes #819
Documentation PR
N/A — docs updated inline (
docs/commands.md)Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.