Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_windows_shell_quote()only escapes for the MSVC C runtime argv parser (backslashes and double quotes) butdoes not account for
cmd.exemetacharacters. WhenExternalAliasCommandpasses user-supplied arguments throughsubprocess.call(command, shell=True), the string is interpreted bycmd.exebefore reaching the target process, meaning metacharacters aren't properly escaped.This PR fixes the issue by always double-quoting the alias value string when
shell=True, automatically treating metacharacters as literals.NOTE:
%VAR%expansion and!VAR!delayed expansion cannot be reliably escaped inside double quotes incmd.exe /c.%%doubling only works in batch file mode. There is no known reliable escape for%or!inside double quotes on the command line.