test: add NIP-22 created_at integration coverage#547
Conversation
|
coverage: 74.929% (+0.2%) from 74.712% — Priyanshubhartistm:feat/integration-tests-nip-22-timestamp-limits into cameri:main |
There was a problem hiding this comment.
Pull request overview
Adds Cucumber integration coverage for NIP-22 created_at timestamp limit enforcement, ensuring events with implausible timestamps are accepted/rejected as configured.
Changes:
- Add new
@nip-22integration feature + step definitions to exercisecreatedAt.maxPositiveDelta/maxNegativeDelta. - Update
EventMessageHandler’s “too far in the future” reason prefix fromrejected:toinvalid:and align the corresponding unit test expectation. - Add a Changesets entry (currently marked as empty/tests-only).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/handlers/event-message-handler.spec.ts | Updates expectation to match the new invalid: prefix for future created_at rejection. |
| test/integration/features/nip-22/nip-22.feature.ts | Adds step defs to set created_at limits and draft/send events with relative timestamps. |
| test/integration/features/nip-22/nip-22.feature | Adds scenarios for accepted/rejected created_at timestamps around configured deltas. |
| src/handlers/event-message-handler.ts | Changes rejection reason prefix for future created_at limit from rejected: to invalid:. |
| .changeset/nip-22-created-at-tests-empty.md | Adds an “empty” changeset despite the PR also changing runtime behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const setCreatedAtLimits = (maxPositiveDelta: number, maxNegativeDelta: number) => { | ||
| const settings = SettingsStatic._settings ?? SettingsStatic.createSettings() | ||
|
|
||
| SettingsStatic._settings = pipe( | ||
| assocPath(['limits', 'event', 'createdAt', 'maxPositiveDelta'], maxPositiveDelta), | ||
| assocPath(['limits', 'event', 'createdAt', 'maxNegativeDelta'], maxNegativeDelta), | ||
| )(settings) as any | ||
| } | ||
|
|
||
| After({ tags: '@nip-22' }, function() { | ||
| setCreatedAtLimits(900, 0) | ||
| }) |
There was a problem hiding this comment.
The @nip-22 After hook resets created_at limits to hard-coded defaults (900/0). Integration tests globally override limits.event.createdAt.maxPositiveDelta to 0 in test/integration/features/shared.ts to avoid time-based flakiness; restoring to 900 here will leak settings changes into subsequent scenarios/features and can cause flaky failures. Snapshot the previous settings (or previous createdAt limits) before modifying, and restore that snapshot in After instead of hard-coding values.
| limits.createdAt.maxPositiveDelta > 0 && | ||
| event.created_at > now + limits.createdAt.maxPositiveDelta | ||
| ) { | ||
| return `rejected: created_at is more than ${limits.createdAt.maxPositiveDelta} seconds in the future` | ||
| return `invalid: created_at is more than ${limits.createdAt.maxPositiveDelta} seconds in the future` | ||
| } |
There was a problem hiding this comment.
This change alters the OK failure reason prefix from rejected: to invalid: for a production validation path. The PR title/description indicate only test additions, and the changeset added is marked as an empty tests-only change; either update the PR description/changeset to reflect this user-visible protocol change (and ensure it’s intended), or keep behavior consistent with the existing rejected: semantics.
| --- | ||
| --- | ||
|
|
||
| Add empty changeset for NIP-22 created_at integration test coverage (issue #505). |
There was a problem hiding this comment.
This changeset is declared as empty/tests-only, but this PR also changes runtime behavior in EventMessageHandler (switching a rejection reason prefix to invalid:). If that behavior change is kept, the changeset should include the appropriate package release entry (or the code change should be moved/reverted so the changeset matches the PR scope).
Priyanshubhartistm
force-pushed
the
feat/integration-tests-nip-22-timestamp-limits
branch
from
5978029 to
cbec93c
Compare
Priyanshubhartistm
force-pushed
the
feat/integration-tests-nip-22-timestamp-limits
branch
from
62ef026 to
32ac52e
Compare
|
@cameri thanku |
Description
Added integration tests for NIP-22
created_attimestamp limits as requested in issue #505.These tests verify that the relay correctly enforces:
createdAt.maxPositiveDelta(default: 900 seconds)createdAt.maxNegativeDelta(default: 0 = unlimited)Related Issue
Closes #505
Motivation and Context
Currently, there were no integration tests covering the timestamp validation logic for event
created_atfield.This PR adds proper Cucumber integration tests to ensure events with implausible timestamps (too far in future or past) are rejected while valid ones are accepted.
How Has This Been Tested?
test/integration/features/nip-22/nip-22.featuretest/integration/features/nip-22/nip-22.feature.tsmaxNegativeDelta→ rejectedmaxNegativeDelta→ acceptedTypes of changes
Checklist: