Skip to content

ENT-13827/13828/13832: Checks for validity of attribute names and number of arguments#67

Merged
olehermanse merged 5 commits intocfengine:mainfrom
SimonThalvorsen:ent-27/28/32
Apr 17, 2026
Merged

ENT-13827/13828/13832: Checks for validity of attribute names and number of arguments#67
olehermanse merged 5 commits intocfengine:mainfrom
SimonThalvorsen:ent-27/28/32

Conversation

@SimonThalvorsen
Copy link
Copy Markdown
Contributor

No description provided.

@SimonThalvorsen SimonThalvorsen force-pushed the ent-27/28/32 branch 3 times, most recently from 3851b7a to b305ad5 Compare April 17, 2026 11:16
Comment thread src/cfengine_cli/lint.py Outdated
Comment thread src/cfengine_cli/lint.py Outdated
@SimonThalvorsen SimonThalvorsen changed the title ENT-13827/28/32 ENT-13827/13828/13832: Checks for validity of attribute names and number of arguments Apr 17, 2026
Comment thread tests/lint/012_invalid_attributes.expected.txt Outdated
Comment thread tests/lint/012_invalid_attributes.expected.txt Outdated
Comment thread tests/lint/013_invalid_num_args_func.cf Outdated
Comment thread tests/lint/013_invalid_num_args_func.cf Outdated
Comment thread src/cfengine_cli/lint.py Outdated
Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
Comment thread src/cfengine_cli/lint.py Outdated
Comment thread src/cfengine_cli/lint.py Outdated
Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
Issue:
Variadic is not consistent in use, some functions(readfile) require 1-N
arguments, whilst others (getgroups/getusers) can take 0-N.
Errormessage default to "expected 1-N, recieved X" as this is the most
common I think.

Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
Comment thread tests/lint/013_function_call_arg_count.cf
@olehermanse olehermanse merged commit c19ea88 into cfengine:main Apr 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants