perf(worker): Batch load flag comparison data#795
Open
sentry[bot] wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 1306 1306
Lines 48004 48012 +8
Branches 1636 1636
=======================================
+ Hits 44286 44294 +8
Misses 3407 3407
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ECDN-WORKER-E4T. The issue was that: ComputeComparison task executes N+1 database queries for RepositoryFlag and CompareFlag within a loop, causing performance degradation.
RepositoryFlagandCompareFlagrecords.INclauses.db_session.flush()calls by creating newRepositoryFlagrecords in a batch.This fix was generated by Seer in Sentry, triggered by Tom Hu. 👁️ Run ID: 13259210
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Medium Risk
Refactors database read/write flow for flag comparison persistence; while intended to be behavior-preserving, changes batching/flush timing and
IN-clause queries could affect correctness or edge cases (e.g., empty flags) and should be validated in production-like DBs.Overview
Reduces N+1 queries when storing flag comparison results by batch-loading
RepositoryFlagandCompareFlagrows usingINfilters, creating any missingRepositoryFlags in-memory, and doing a singleflush()to assign IDs before processing per-flag totals.Flag comparison updates/inserts now rely on in-memory maps (
flag_name -> RepositoryFlag,repositoryflag_id -> CompareFlag) rather than querying inside the loop, improving worker performance for repos with many flags.Reviewed by Cursor Bugbot for commit 45b28b2. Bugbot is set up for automated code reviews on this repo. Configure here.