Skip to content

perf(worker): Batch load flag comparison data#795

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-load-flag-comparison
Open

perf(worker): Batch load flag comparison data#795
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-load-flag-comparison

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Apr 14, 2026

Fixes ECDN-WORKER-E4T. The issue was that: ComputeComparison task executes N+1 database queries for RepositoryFlag and CompareFlag within a loop, causing performance degradation.

  • Optimized database queries for RepositoryFlag and CompareFlag records.
  • Replaced individual queries within a loop with batch loading using IN clauses.
  • Reduced the number of db_session.flush() calls by creating new RepositoryFlag records in a batch.
  • Improves performance by addressing N+1 query issues when storing flag comparison data.

This fix was generated by Seer in Sentry, triggered by Tom Hu. 👁️ Run ID: 13259210

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Medium Risk
Refactors database read/write flow for flag comparison persistence; while intended to be behavior-preserving, changes batching/flush timing and IN-clause queries could affect correctness or edge cases (e.g., empty flags) and should be validated in production-like DBs.

Overview
Reduces N+1 queries when storing flag comparison results by batch-loading RepositoryFlag and CompareFlag rows using IN filters, creating any missing RepositoryFlags in-memory, and doing a single flush() to assign IDs before processing per-flag totals.

Flag comparison updates/inserts now rely on in-memory maps (flag_name -> RepositoryFlag, repositoryflag_id -> CompareFlag) rather than querying inside the loop, improving worker performance for repos with many flags.

Reviewed by Cursor Bugbot for commit 45b28b2. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (8c332b1) to head (45b28b2).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #795   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1306     1306           
  Lines       48004    48012    +8     
  Branches     1636     1636           
=======================================
+ Hits        44286    44294    +8     
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.55% <0.00%> (-0.03%) ⬇️
workerunit 90.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants