perf(worker): Optimize flake processing by pre-fetching testruns#797
Open
sentry[bot] wants to merge 1 commit intomainfrom
Open
perf(worker): Optimize flake processing by pre-fetching testruns#797sentry[bot] wants to merge 1 commit intomainfrom
sentry[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
==========================================
- Coverage 92.25% 92.25% -0.01%
==========================================
Files 1306 1306
Lines 48004 48014 +10
Branches 1636 1636
==========================================
+ Hits 44286 44293 +7
- Misses 3407 3410 +3
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WORKER-Y73. The issue was that: ProcessFlakesTask's N+1 queries for testruns and flags per upload cause hard_timeout.
get_testruns_for_uploadsto efficiently fetch testruns for multiple uploads in a single query.process_single_uploadto accept an optional list of pre-fetched testruns, avoiding redundant database calls.process_flakes_for_committo utilize the new batched fetching mechanism, significantly reducing the number of database queries when processing flakes for a commit with multiple uploads.This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13274732
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Medium Risk
Changes flake-processing data access patterns by batching
Testrunqueries across uploads; behavior should be equivalent but mistakes in grouping/empty-upload handling could impact which testruns get processed or updated.Overview
Optimizes
process_flakes_for_commitflake detection by prefetching all recentTestruns for the commit’s uploads in a single query and grouping them per upload, instead of querying per upload.Updates
process_single_uploadto accept an optional pre-fetchedtestrunslist (falling back to the old per-upload query), and passes the grouped results through to avoid N+1 DB calls and reduce worker timeouts.Reviewed by Cursor Bugbot for commit 836a08d. Bugbot is set up for automated code reviews on this repo. Configure here.