fix(worker): Robustify bundle analysis error handling with explicit upload_id and session rollbacks#804
Open
sentry[bot] wants to merge 1 commit intomainfrom
Open
Conversation
…pload_id and session rollbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WORKER-Y79. The issue was that: Concurrent cleanup deleted the
Uploadrecord, causingStaleDataErrorduring update, leading toPendingRollbackErroron subsequent lazy-load.upload_idas a plain integer early in the bundle analysis processing to ensure its availability for logging.upload_idexplicitly to the_set_upload_error_and_commitfunction for more reliable error logging.db_session.rollback()calls within exception handlers to reset the SQLAlchemy session state, preventing issues like 'session is DEACTIVE' when attempting to log or update upload status after a database error (e.g.,StaleDataError).This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13291765
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Medium Risk
Touches bundle analysis upload processing and error paths, including transaction rollbacks and upload state updates; mistakes here could change retry/error behavior or leave uploads in incorrect states.
Overview
Improves bundle analysis processor resilience when the
Uploadrow disappears mid-processing (e.g., cleanup causingStaleDataError). It now captures a stableupload_idearly for logging, explicitly rolls back the SQLAlchemy session before logging/fallback updates after commit/update failures, and threadsupload_idinto_set_upload_error_and_commitso error logs don’t depend on potentially-deactivated ORM objects.Reviewed by Cursor Bugbot for commit 729ddcf. Bugbot is set up for automated code reviews on this repo. Configure here.