Skip to content

perf(worker): Cache commit objects for Pull and CommitStatus#810

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/cache-commit-objects
Open

perf(worker): Cache commit objects for Pull and CommitStatus#810
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/cache-commit-objects

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Apr 14, 2026

Fixes WORKER-Y7F. The issue was that: Multiple notification context builders repeatedly query the same commit objects, causing an N+1 database query pattern within a Redis-locked task.

  • Utilizes @cached_property for base_commit in the CommitStatus context to prevent redundant database queries.
  • Implements manual caching for get_head_commit and get_comparedto_commit methods on the Pull model to avoid repeated database lookups for the same commit objects.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13304620

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Low Risk
Low risk performance change that only memoizes commit lookups within a model/context instance; main risk is subtle staleness if the same Pull object is reused after head/compared_to changes in-memory.

Overview
Reduces N+1-style database access during bundle analysis notifications by caching commit objects.

Pull.get_head_commit() and Pull.get_comparedto_commit() now memoize the fetched Commit on the model instance, and CommitStatusNotificationContext.base_commit is switched to @cached_property to avoid repeated base-commit resolution within a single notification build.

Reviewed by Cursor Bugbot for commit 09195a4. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (8c332b1) to head (09195a4).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #810   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1306     1306           
  Lines       48004    48009    +5     
  Branches     1636     1636           
=======================================
+ Hits        44286    44291    +5     
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.59% <100.00%> (+0.01%) ⬆️
workerunit 90.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants