perf(worker): Cache commit objects for Pull and CommitStatus#810
Open
sentry[bot] wants to merge 1 commit intomainfrom
Open
perf(worker): Cache commit objects for Pull and CommitStatus#810sentry[bot] wants to merge 1 commit intomainfrom
sentry[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #810 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 1306 1306
Lines 48004 48009 +5
Branches 1636 1636
=======================================
+ Hits 44286 44291 +5
Misses 3407 3407
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WORKER-Y7F. The issue was that: Multiple notification context builders repeatedly query the same commit objects, causing an N+1 database query pattern within a Redis-locked task.
@cached_propertyforbase_commitin theCommitStatuscontext to prevent redundant database queries.get_head_commitandget_comparedto_commitmethods on thePullmodel to avoid repeated database lookups for the same commit objects.This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13304620
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Low Risk
Low risk performance change that only memoizes commit lookups within a model/context instance; main risk is subtle staleness if the same
Pullobject is reused afterhead/compared_tochanges in-memory.Overview
Reduces N+1-style database access during bundle analysis notifications by caching commit objects.
Pull.get_head_commit()andPull.get_comparedto_commit()now memoize the fetchedCommiton the model instance, andCommitStatusNotificationContext.base_commitis switched to@cached_propertyto avoid repeated base-commit resolution within a single notification build.Reviewed by Cursor Bugbot for commit 09195a4. Bugbot is set up for automated code reviews on this repo. Configure here.