Skip to content

perf(worker): Batch testrun updates in flake processing#811

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-flake-updates
Open

perf(worker): Batch testrun updates in flake processing#811
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-flake-updates

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Apr 14, 2026

Fixes WORKER-Y7G. The issue was that: Missing eager loading of Testrun objects for ReportSessions causes N+1 queries within process_flakes_for_commit loop.

  • Refactored get_testruns into get_testruns_for_uploads to fetch testruns for multiple uploads simultaneously.
  • Modified process_single_upload to accept pre-fetched testruns, eliminating individual database queries within the loop.
  • Consolidated Testrun outcome bulk updates into a single operation within process_flakes_for_commit after all uploads have been processed.
  • Improved database efficiency by reducing the number of queries for testruns and bulk update operations during flake processing.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13305954

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Medium Risk
Changes the query/update strategy for Testrun rows during flake processing (batch fetch + deferred bulk update), which could impact correctness if upload scoping or update ordering assumptions were relied on, though overall logic is unchanged.

Overview
Reduces N+1 queries in flake processing by fetching all recent Testrun rows for a commit’s uploads in a single query (get_testruns_for_uploads) and grouping them by upload_id.

Refactors process_single_upload to operate on pre-fetched testruns and defers all Testrun.outcome writes into one bulk_update after processing all uploads, instead of updating per upload.

Reviewed by Cursor Bugbot for commit 6fdc95b. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6fdc95b. Configure here.

@sentry_sdk.trace
def process_single_upload(
upload: ReportSession, curr_flakes: dict[bytes, Flake], repo_id: int
upload_id: int,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused upload_id parameter in process_single_upload

Low Severity

The upload_id parameter was added to process_single_upload but is never referenced in the function body. The function only iterates over the testruns list and uses curr_flakes and repo_id. This dead parameter adds confusion about the function's contract and could mislead future developers into thinking it's used internally.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 6fdc95b. Configure here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@sentry
Copy link
Copy Markdown
Contributor Author

sentry bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (8c332b1) to head (6fdc95b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #811   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1306     1306           
  Lines       48004    48012    +8     
  Branches     1636     1636           
=======================================
+ Hits        44286    44294    +8     
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.56% <13.33%> (-0.03%) ⬇️
workerunit 90.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants