Support participation-condition Storybook fixture workflows#62
Closed
Support participation-condition Storybook fixture workflows#62
Conversation
✅ Deploy Preview for competition-groups ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
coder13
force-pushed
the
participation-condition
branch
from
b808cca to
433c1e4
Compare
coder13
force-pushed
the
participation-condition
branch
from
433c1e4 to
ef9d104
Compare
coder13
commented
Apr 20, 2026
| : 'common.wca.advancement.resultAchieved', | ||
| { | ||
| defaultValue: isLinkedRounds | ||
| ? 'Competitors with a {{scope}} better than {{result}} combined across {{rounds}} advance to next round. Minimum of 25% of competitors must be eliminated.' |
Owner
Author
There was a problem hiding this comment.
This bit of text needs to be moved to the translation files.
coder13
commented
Apr 20, 2026
| const cutoff = round.cutoff; | ||
| const timeLimit = round.timeLimit; | ||
| const timelimitTime = timeLimit && renderCentiseconds(timeLimit?.centiseconds); | ||
| const eventRounds = useMemo(() => { |
Owner
Author
There was a problem hiding this comment.
This looks like generic code we could move to a helper function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification