docs: call out wallet funding prerequisite for DDO scheduling#668
Open
docs: call out wallet funding prerequisite for DDO scheduling#668
Conversation
deal-pusher already logs warnings when the wallet has insufficient FIL for gas or zero payment tokens (service/dealpusher/ddo_schedule.go:120, 128), but the guides told users to 'attach a wallet' without mentioning that it needs to be funded with both FIL and the payment token before the first schedule runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both the DDO migration guide and the DDO contract deal guide told users to "attach a wallet" without mentioning that the wallet needs to be funded with both FIL (for gas) and the configured payment token (for deals) before scheduling starts.
`deal-pusher` already logs warnings for both conditions at schedule startup (`service/dealpusher/ddo_schedule.go:120` for low FIL, `:128` for zero tokens + zero deposited), but without a doc hint the user is most likely to hit this and read the log after the fact.
Changes
Test plan