fix(android): ensure enable() promise waits for PoweredOn state before resolving#1336
Open
alexviar wants to merge 1 commit intodotintent:masterfrom
Open
fix(android): ensure enable() promise waits for PoweredOn state before resolving#1336alexviar wants to merge 1 commit intodotintent:masterfrom
alexviar wants to merge 1 commit intodotintent:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical bug on Android where the
enable()promise resolves prematurely before the Bluetooth adapter has actually completed the transition toPoweredOn.The Problem:
In
BleModule.java, the state change logic usestakeUntilfollowed byfirstOrError. SinceRxBleAdapterStateObservableemits the current state immediately upon subscription, if the adapter isSTATE_OFF, the stream emits this value (which passes thetakeUntilpredicate as it's not the final state) andfirstOrErrorresolves the JS promise instantly.The Solution:
Replacing
takeUntilwithfilterensures the sequence only continues (and thus resolves the promise) when the desired state is actually reached.