Skip to content

Browscap mapping#418

Open
bidi47 wants to merge 6 commits into7.0from
browscap
Open

Browscap mapping#418
bidi47 wants to merge 6 commits into7.0from
browscap

Conversation

@bidi47
Copy link
Copy Markdown
Member

@bidi47 bidi47 commented Apr 17, 2026

No description provided.

@bidi47 bidi47 linked an issue Apr 17, 2026 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2026

Qodana for JS

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@bidi47 bidi47 requested review from alexmerlin and arhimede April 17, 2026 10:35
Comment thread src/Admin/src/Service/AdminLoginService.php Outdated
Comment thread src/Admin/src/Service/AdminLoginService.php Outdated
@arhimede
Copy link
Copy Markdown
Member

@bidi47 can you fix the missing DCO ?

@arhimede
Copy link
Copy Markdown
Member

I would like to see a test to cover this ?
I am asking too mucho ?

bidi47 added 4 commits April 17, 2026 15:43
Signed-off-by: bidi <bidi@apidemia.com>
Signed-off-by: bidi <bidi@apidemia.com>
Signed-off-by: bidi <bidi@apidemia.com>
Signed-off-by: bidi <bidi@apidemia.com>
Signed-off-by: bidi <bidi@apidemia.com>
Comment thread src/Admin/src/Service/AdminLoginService.php Outdated
Signed-off-by: bidi <bidi@apidemia.com>
@arhimede
Copy link
Copy Markdown
Member

where is the migration file ?

@arhimede
Copy link
Copy Markdown
Member

that's why i need a diff generated
and a proper entity structure

image

@bidi47
Copy link
Copy Markdown
Member Author

bidi47 commented Apr 21, 2026

i tested with this migration
it updates the required columns in the admin_login table

Version20260421110134.php

@arhimede
Copy link
Copy Markdown
Member

Now we need this migration for Postgresql ..

@arhimede
Copy link
Copy Markdown
Member

@alexmerlin

what we are missing here is the definition of Enum for iscrawler for the modified table admin_login
Similar to this one : https://github.com/dotkernel/admin/blob/7.0/src/Core/src/Admin/src/Enum/AdminStatusEnum.php
This is one problem which need to be handled if one want to switch easy between mariqadb and postgres

@alexmerlin
Copy link
Copy Markdown
Member

@alexmerlin

what we are missing here is the definition of Enum for iscrawler for the modified table admin_login Similar to this one : https://github.com/dotkernel/admin/blob/7.0/src/Core/src/Admin/src/Enum/AdminStatusEnum.php This is one problem which need to be handled if one want to switch easy between mariqadb and postgres

The isCrawler property uses the existing YesNoEnum type as the isMobile property:

    #[ORM\Column(type: 'yes_no_enum', nullable: true, enumType: YesNoEnum::class)]
    protected YesNoEnum $isMobile = YesNoEnum::No;
    #[ORM\Column(type: 'yes_no_enum', nullable: true, enumType: YesNoEnum::class)]
    protected YesNoEnum $isCrawler = YesNoEnum::No;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implement browsecap

3 participants